Merge pull request #454 from hanazuki/node-addon-api@8.8.0

node-addon-api@8.8.0

Author: hanazuki

package-lock.json

@@ -82,7 +82,7 @@
   "dependencies": {
     "bindings": "^1.5.0",
     "cmake-js": "^8.0.0",
-    "node-addon-api": "^8.5.0"
+    "node-addon-api": "^8.8.0"
   },
   "devDependencies": {
     "@types/node": "20",

package.json

@@ -28,7 +28,7 @@ namespace nodejsonnet {
       return Napi::Number::New(env, *n);
     }
     if(auto const s = vm->extractJsonString(json)) {
-      return Napi::String::New(env, s->data(), s->size());
+      return Napi::String::New(env, *s);
     }
 
     // NOTREACHED

src/JsonValueConverter.cpp

@@ -79,8 +79,7 @@ namespace nodejsonnet {
         std::string_view const json(p);
         p += json.size() + 1;
 
-        result.Set(Napi::String::New(env, name.data(), name.size()),
-          Napi::String::New(env, json.data(), json.size()));
+        result.Set(Napi::String::New(env, name), Napi::String::New(env, json));
       }
 
       return result;
@@ -110,7 +109,7 @@ namespace nodejsonnet {
       for(auto p = buffer.get(); *p;) {
         std::string_view const json(p);
         p += json.size() + 1;
-        jsons.push_back(Napi::String::New(env, json.data(), json.size()));
+        jsons.push_back(Napi::String::New(env, json));
       }
 
       auto result = Napi::Array::New(env, jsons.size());