Update of the available options, hooks and dependencies. (#112)

* Updated: inputs and their definitions. Added: ts-ignore to ce-settings-resolver, it's a temporary workaround, until we fix our handsontable.d.ts. #109

* Added: @ts-ingore to imports packages from paths. #109

* Added: tests. Updated: package-lock. #109

* Missing changes in peerDeps and travis config. #109

Author: swistach

.travis.yml

@@ -3,7 +3,7 @@ language: node_js
 sudo: false
 
 node_js:
-  - '6'
+  - '8'
 
 before_script:
   - 'export CHROME_BIN=chromium-browser'

lib/ce/package.json

@@ -1,9 +1,8 @@
 {
   "name": "@handsontable/angular",
-  "version": "1.0.0-beta4",
   "keywords": [],
   "peerDependencies": {
-    "handsontable": "^4.0.0",
+    "handsontable": "^5.0.0",
     "zone.js": "^0.8.19"
   },
   "ngPackage": {

lib/ce/src/hot-column.component.ts

@@ -5,18 +5,16 @@ import {
   OnDestroy,
   Input,
 } from '@angular/core';
-
 import { HotTableComponent } from './hot-table.component';
 
 @Component({
   // tslint:disable-next-line
   selector: 'hot-column',
   template: '',
 })
-
 export class HotColumnComponent implements OnInit, OnChanges, OnDestroy {
   private firstRun = true;
-
+  // handsontable column options
   @Input() allowEmpty: boolean;
   @Input() allowHtml: boolean;
   @Input() allowInvalid: boolean;
@@ -59,20 +57,20 @@ export class HotColumnComponent implements OnInit, OnChanges, OnDestroy {
 
   constructor(private parentComponent: HotTableComponent) {}
 
-  ngOnInit() {
+  ngOnInit(): void {
     this.firstRun = false;
     this.parentComponent.addColumn(this);
   }
 
-  ngOnChanges() {
+  ngOnChanges(): void {
     if (this.firstRun) {
       return;
     }
 
     this.parentComponent.onAfterColumnsChange();
   }
 
-  ngOnDestroy() {
+  ngOnDestroy(): void {
     this.parentComponent.removeColumn(this);
   }
 }

lib/ce/src/hot-settings-resolver.service.ts

@@ -1,58 +1,17 @@
 import { Injectable, SimpleChanges } from '@angular/core';
-
-const AVAILABLE_OPTIONS: string[] = ['activeHeaderClassName', 'allowEmpty', 'allowHtml', 'allowInsertColumn', 'allowInsertRow',
-'allowInvalid', 'allowRemoveColumn', 'allowRemoveRow', 'autoColumnSize', 'autoComplete', 'autoRowSize',
-'autoWrapCol', 'autoWrapRow', 'cell', 'cells', 'checkedTemplate', 'className', 'colHeaders', 'columnHeaderHeight',
-'columns', 'columnSorting', 'colWidths', 'commentedCellClassName', 'comments', 'contextMenu', 'copyable',
-'copyPaste', 'correctFormat', 'currentColClassName', 'currentHeaderClassName', 'currentRowClassName',
-'customBorders', 'data', 'dataSchema', 'dateFormat', 'debug', 'defaultDate', 'disableVisualSelection',
-'dragToScroll', 'editor', 'enterBeginsEditing', 'enterMoves', 'fillHandle', 'filter', 'filteringCaseSensitive',
-'fixedColumnsLeft', 'fixedRowsTop', 'fragmentSelection', 'height', 'invalidCellClassName', 'label',
-'language', 'manualColumnFreeze', 'manualColumnMove', 'manualColumnResize', 'manualRowMove', 'manualRowResize',
-'maxCols', 'maxRows', 'mergeCells', 'minCols', 'minRows', 'minSpareCols', 'minSpareRows', 'multiSelect',
-'noWordWrapClassName', 'numericFormat', 'observeChanges', 'observeDOMVisibility', 'outsideClickDeselects',
-'persistentState', 'placeholder', 'placeholderCellClassName', 'preventOverflow', 'readOnly',
-'readOnlyCellClassName', 'renderAllRows', 'renderer', 'rowHeaders', 'rowHeaderWidth', 'rowHeights',
-'search', 'selectionMode', 'selectOptions', 'skipColumnOnPaste', 'sortByRelevance', 'sortFunction', 'sortIndicator',
-'source', 'startCols', 'startRows', 'stretchH', 'strict', 'tableClassName', 'tabMoves', 'title',
-'trimDropdown', 'trimWhitespace', 'type', 'uncheckedTemplate', 'undo', 'validator',
-'viewportColumnRenderingOffset', 'viewportRowRenderingOffset', 'visibleRows', 'width', 'wordWrap'];
-
-const AVAILABLE_HOOKS: string[] = ['afterBeginEditing', 'afterCellMetaReset', 'afterChange',
-'afterChangesObserved', 'afterColumnMove', 'afterColumnResize', 'afterColumnSort',
-'afterContextMenuDefaultOptions', 'afterContextMenuHide', 'afterContextMenuShow', 'afterCopy',
-'afterCopyLimit', 'afterCreateCol', 'afterCreateRow', 'afterCut', 'afterDeselect', 'afterDestroy',
-'afterDocumentKeyDown', 'afterGetCellMeta', 'afterGetColHeader', 'afterGetColumnHeaderRenderers',
-'afterGetRowHeader', 'afterGetRowHeaderRenderers', 'afterInit', 'afterLanguageChange', 'afterListen',
-'afterLoadData', 'afterModifyTransformEnd', 'afterModifyTransformStart', 'afterMomentumScroll',
-'afterOnCellCornerDblClick', 'afterOnCellCornerMouseDown', 'afterOnCellMouseDown',
-'afterOnCellMouseOut', 'afterOnCellMouseOver', 'afterPaste', 'afterPluginsInitialized', 'afterRedo',
-'afterRemoveCellMeta', 'afterRemoveCol', 'afterRemoveRow', 'afterRender', 'afterRenderer',
-'afterRowMove', 'afterRowResize', 'afterScrollHorizontally', 'afterScrollVertically', 'afterSelection',
-'afterSelectionByProp', 'afterSelectionEnd', 'afterSelectionEndByProp', 'afterSetCellMeta',
-'afterSetDataAtCell', 'afterSetDataAtRowProp', 'afterUndo', 'afterUnlisten', 'afterUpdateSettings',
-'afterValidate', 'afterViewportColumnCalculatorOverride', 'afterViewportRowCalculatorOverride',
-'beforeAutofill', 'beforeAutofillInsidePopulate', 'beforeCellAlignment', 'beforeChange', 'beforeChangeRender',
-'beforeColumnMove', 'beforeColumnResize', 'beforeColumnSort', 'beforeContextMenuSetItems', 'beforeCopy',
-'beforeCreateCol', 'beforeCreateRow', 'beforeCut', 'beforeDrawBorders', 'beforeGetCellMeta', 'beforeInit',
-'beforeInitWalkontable', 'beforeKeyDown', 'beforeLanguageChange', 'beforeOnCellMouseDown', 'beforeOnCellMouseOut',
-'beforeOnCellMouseOver', 'beforePaste', 'beforeRedo', 'beforeRemoveCellMeta', 'beforeRemoveCol',
-'beforeRemoveRow', 'beforeRender', 'beforeRenderer', 'beforeRowMove', 'beforeRowResize', 'beforeSetRangeEnd',
-'beforeSetRangeStart', 'beforeStretchingColumnWidth', 'beforeTouchScroll', 'beforeUndo', 'beforeValidate',
-'beforeValueRender', 'construct', 'init', 'manualRowHeights', 'modifyAutofillRange', 'modifyCol',
-'modifyColHeader', 'modifyColumnHeaderHeight', 'modifyColWidth', 'modifyCopyableRange', 'modifyData',
-'modifyRow', 'modifyRowData', 'modifyRowHeader', 'modifyRowHeaderWidth', 'modifyRowHeight', 'modifyTransformEnd',
-'modifyTransformStart', 'persistentStateLoad', 'persistentStateReset', 'persistentStateSave',
-'skipLengthCache', 'unmodifyCol', 'unmodifyRow'];
+import * as Handsontable from 'handsontable';
+// @ts-ignore
+const AVAILABLE_OPTIONS: string[] = Object.keys(Handsontable.DefaultSettings.prototype);
+// @ts-ignore
+const AVAILABLE_HOOKS: string[] = Handsontable.hooks.getRegistered();
 
 @Injectable()
 export class HotSettingsResolver {
-
-  mergeSettings(component): object {
-    const mergedSettings: object = {};
+  mergeSettings(component): Handsontable.GridSettings {
+    const mergedSettings: Handsontable.GridSettings = {};
     const options = AVAILABLE_HOOKS.concat(AVAILABLE_OPTIONS);
 
-    options.forEach((key) => {
+    options.forEach(key => {
       let option;
 
       if (typeof component['settings'] === 'object') {
@@ -81,8 +40,8 @@ export class HotSettingsResolver {
     return mergedSettings;
   }
 
-  prepareChanges(changes: SimpleChanges): object {
-    const result: object = {};
+  prepareChanges(changes: SimpleChanges): Handsontable.GridSettings {
+    const result: Handsontable.GridSettings = {};
     const parameters: string[] = Object.keys(changes);
 
     parameters.forEach((param) => {

lib/ce/src/hot-table-registerer.service.ts

@@ -1,5 +1,4 @@
 import { Injectable } from '@angular/core';
-
 import * as Handsontable from 'handsontable';
 
 const instances = new Map<string, Handsontable>();
@@ -10,11 +9,11 @@ export class HotTableRegisterer {
     return instances.get(id);
   }
 
-  public registerInstance(id: string, instance: Handsontable): void {
-    instances.set(id, instance);
+  public registerInstance(id: string, instance: Handsontable): Map<string, Handsontable> {
+    return instances.set(id, instance);
   }
 
-  public removeInstance(id: string): void {
-    instances.delete(id);
+  public removeInstance(id: string): boolean {
+    return instances.delete(id);
   }
 }