Added: test spec, tslint rule no-unused-variable, Removed: unnecessary import. #76 (#88)

Author: swistach

lib/ce/src/hot-column.component.ts

@@ -1,6 +1,5 @@
 import {
   Component,
-  Injector,
   OnInit,
   OnChanges,
   OnDestroy,
@@ -100,7 +99,6 @@ export class HotColumnComponent implements OnInit, OnChanges, OnDestroy {
   @Input() rowHeaderWidth: number | number[];
   @Input() rowHeights: number | number[] | string | ((row: number) => number);
   @Input() search: boolean;
-  @Input() selectionMode: string;
   @Input() selectOptions: string[] | number[];
   @Input() skipColumnOnPaste: boolean;
   @Input() sortByRelevance: boolean;

lib/pro/src/hot-column.component.ts

@@ -1,6 +1,5 @@
 import {
   Component,
-  Injector,
   OnInit,
   OnChanges,
   OnDestroy,
@@ -101,7 +100,6 @@ export class HotColumnComponent implements OnInit, OnChanges, OnDestroy {
   @Input() rowHeaderWidth: number | number[];
   @Input() rowHeights: number | number[] | string | ((row: number) => number);
   @Input() search: boolean;
-  @Input() selectionMode: string;
   @Input() selectOptions: string[] | number[];
   @Input() skipColumnOnPaste: boolean;
   @Input() sortByRelevance: boolean;

src/app/hot-column.component.spec.ts

@@ -1,5 +1,4 @@
 import { ComponentFixture, TestBed } from '@angular/core/testing';
-import * as Handsontable from 'handsontable-pro';
 
 import { HotTableModule } from '@handsontable-pro/angular';
 import { TestComponent } from './test.component';

src/app/hot-table.component.spec.ts

@@ -1656,6 +1656,29 @@ describe('HotTableComponent', () => {
       });
     });
 
+    it(`should set selectionMode defined as bindings`, () => {
+      TestBed.overrideComponent(TestComponent, {
+        set: {
+          template: `<hot-table [hotId]="id" [selectionMode]="prop.selectionMode"></hot-table>`
+        }
+      });
+      TestBed.compileComponents().then(() => {
+        fixture = TestBed.createComponent(TestComponent);
+        const app = fixture.componentInstance;
+
+        fixture.detectChanges();
+        expect(app.getHotInstance(app.id).getSettings()['selectionMode']).toBe('multiple');
+
+        app.prop['selectionMode'] = 'single';
+        fixture.detectChanges();
+        expect(app.getHotInstance(app.id).getSettings()['selectionMode']).toBe('single');
+
+        app.prop['selectionMode'] = 'range';
+        fixture.detectChanges();
+        expect(app.getHotInstance(app.id).getSettings()['selectionMode']).toBe('range');
+      });
+    });
+
     it(`should set selectOptions defined as bindings`, () => {
       TestBed.overrideComponent(TestComponent, {
         set: {

tslint.json

@@ -54,6 +54,7 @@
     "no-switch-case-fall-through": true,
     "no-trailing-whitespace": true,
     "no-unused-expression": true,
+    "no-unused-variable": true,
     "no-use-before-declare": true,
     "no-var-keyword": true,
     "object-literal-sort-keys": false,