Configure eslint for spec files (#1564)

* Added eslint-plugin-jasmine and eslint-plugin-jest

* Fix eslint-plugin-jest errors

* Remove duplicated tests

Author: sequba

.eslintrc.js

@@ -6,7 +6,13 @@ module.exports = {
     '@typescript-eslint',
     'license-header',
     'jsdoc',
+    'jasmine',
+    'jest',
   ],
+  env: {
+    jasmine: true,
+    'jest/globals': true,
+  },
   parserOptions: {
     tsconfigRootDir: __dirname,
     project: './tsconfig.test.json',
@@ -17,6 +23,9 @@ module.exports = {
     'plugin:@typescript-eslint/eslint-recommended',
     'plugin:@typescript-eslint/recommended',
     'plugin:@typescript-eslint/recommended-requiring-type-checking',
+    'plugin:jasmine/recommended',
+    'plugin:jest/recommended',
+    'plugin:jest/style',
   ],
   rules: {
     // Automatic fixers
@@ -113,6 +122,13 @@ module.exports = {
         MethodDefinition: true,
       }
     }],
+    'jest/no-jasmine-globals': 'off',
+    'jest/no-alias-methods': 'off',
+    'jest/no-conditional-expect': 'warn',
+    'jest/no-standalone-expect': 'warn',
+    'jest/no-test-prefixes': 'off',
+    'jest/prefer-to-be': 'warn',
+    'jest/prefer-to-have-length': 'warn',
   },
   overrides: [
     {

package-lock.json

@@ -133,6 +133,8 @@
     "env-cmd": "^10.1.0",
     "eslint": "^8.57.1",
     "eslint-config-prettier": "^9.1.0",
+    "eslint-plugin-jasmine": "^4.2.2",
+    "eslint-plugin-jest": "^27.9.0",
     "eslint-plugin-jsdoc": "^50.5.0",
     "eslint-plugin-license-header": "^0.6.1",
     "eslint-plugin-prettier": "^5.2.1",

package.json

@@ -7,13 +7,13 @@ describe('AbsoluteCellRange', () => {
     it('true in simplest case', () => {
       const range = AbsoluteCellRange.fromCoordinates(0, 0, 0, 0, 0)
 
-      expect(range.addressInRange(adr('A1')))
+      expect(range.addressInRange(adr('A1'))).toBe(true)
     })
 
     it('false if different sheets', () => {
       const range = AbsoluteCellRange.fromCoordinates(1, 0, 0, 0, 0)
 
-      expect(range.addressInRange(adr('A1')))
+      expect(range.addressInRange(adr('A1'))).toBe(false)
     })
   })
 

test/unit/AbsoluteCellRange.spec.ts

@@ -3,6 +3,7 @@ import {toEqualError} from './toEqualError'
 beforeAll(() => {
   // eslint-disable-next-line @typescript-eslint/ban-ts-comment
   // @ts-ignore
+  // eslint-disable-next-line no-global-assign
   spyOn = jest.spyOn
   expect.extend(toEqualError)
 })

test/unit/_setupFiles/jest/bootstrap.ts

@@ -380,7 +380,6 @@ describe('build from array', () => {
       [undefined, ArrayVertex, ArrayVertex],
     ])
     expect(engine.arrayMapping.arrayMapping.size).toEqual(4)
-    expect(engine.getSheetValues(0))
   })
 
   it('should REF last array', () => {
@@ -399,7 +398,6 @@ describe('build from array', () => {
       [noSpace(), 2, 2, 1, 2],
     ])
     expect(engine.arrayMapping.arrayMapping.size).toEqual(3)
-    expect(engine.getSheetValues(0))
   })
 
   it('array should work with different types of data', () => {
@@ -490,15 +488,6 @@ describe('column ranges', () => {
     expect(engine.getCellValue(adr('A2'))).toEqualError(detailedError(ErrorType.SPILL, ErrorMessage.NoSpaceForArrayResult))
   })
 
-  it('arithmetic should work for row range', () => {
-    const engine = HyperFormula.buildFromArray([
-      ['=2*(2:2)', null],
-      [1, 2],
-    ], {useArrayArithmetic: true})
-
-    expect(engine.getSheetValues(0)).toEqual([[2, 4], [1, 2]])
-  })
-
   it('arithmetic for shifted row range -- error', () => {
     const engine = HyperFormula.buildFromArray([
       [null, '=2*(2:2)'],

test/unit/arrays.spec.ts

@@ -296,7 +296,7 @@ describe('ColumnIndex#removeColumns', () => {
     expect(index.getValueIndex(0, 0, 1).index).toEqual([])
   })
 
-  it('should remove multiple columns in the middle ', () => {
+  it('should remove multiple columns in the middle', () => {
     const index = buildEmptyIndex(transformingService, new Config(), statistics)
     index.add(1, adr('A1'))
     index.add(2, adr('B1'))
@@ -311,7 +311,7 @@ describe('ColumnIndex#removeColumns', () => {
     expect(index.getValueIndex(0, 3, 4).index).toEqual([])
   })
 
-  it('should remove columns only in one sheet ', () => {
+  it('should remove columns only in one sheet', () => {
     const index = buildEmptyIndex(transformingService, new Config(), statistics)
     index.add(1, adr('A1', 0))
     index.add(1, adr('A1', 1))
@@ -455,7 +455,7 @@ describe('ColumnIndex#removeRows', () => {
     expect(index.getValueIndex(0, 0, 1).index).toEqual([])
   })
 
-  it('should remove rows in the middle ', () => {
+  it('should remove rows in the middle', () => {
     const statistics = new Statistics()
     const transformingService = new LazilyTransformingAstService(statistics)
     const index = buildEmptyIndex(transformingService, new Config(), statistics)

test/unit/column-index.spec.ts

@@ -316,7 +316,7 @@ describe('Adding column, fixing ranges', () => {
     ]))
   })
 
-  it('it should insert new cell with edge to only one range at right', () => {
+  it('should insert new cell with edge to only one range at right', () => {
     const engine = HyperFormula.buildFromArray([
       ['1', '2', /* */ '3', '4'],
       ['=SUM(A1:A1)', '=SUM(A1:B1)', /* */ '=SUM(A1:C1)', '=SUM(A1:D1)'],

test/unit/cruds/adding-columns-dependencies.spec.ts

@@ -332,7 +332,7 @@ describe('Adding row, ranges', () => {
     ]))
   })
 
-  it('it should insert new cell with edge to all ranges below', () => {
+  it('should insert new cell with edge to all ranges below', () => {
     const engine = HyperFormula.buildFromArray([
       ['1', '=SUM(A1:A1)'],
       ['2', '=SUM(A1:A2)'],
@@ -358,7 +358,7 @@ describe('Adding row, ranges', () => {
     expect(engine.graph.adjacentNodesCount(a2)).toBe(1)
   })
 
-  it('it should insert new cell with edge to only one range below, shifted by 1', () => {
+  it('should insert new cell with edge to only one range below, shifted by 1', () => {
     const engine = HyperFormula.buildFromArray([
       ['1', null],
       ['2', '=SUM(A1:A1)'],

test/unit/cruds/adding-row-dependencies.spec.ts

@@ -296,7 +296,7 @@ describe('changing cell content', () => {
     expect(engine.getCellValue(adr('B1'))).toBe(42)
   })
 
-  it('set nothing again', () => {
+  it('set nothing again (2)', () => {
     const sheet = [
       [null],
     ]
@@ -486,15 +486,15 @@ describe('changing cell content', () => {
     expectArrayWithSameContent(changes.map((change) => change.newValue), [2, 10, 12, 18, 22])
   })
 
-  it('update empty cell to parsing error ', () => {
+  it('update empty cell to parsing error', () => {
     const engine = HyperFormula.buildFromArray([])
 
     engine.setCellContents(adr('A1'), '=SUM(')
 
     expect(engine.getCellValue(adr('A1'))).toEqualError(detailedError(ErrorType.ERROR, ErrorMessage.ParseError))
   })
 
-  it('update dependency value cell to parsing error ', () => {
+  it('update dependency value cell to parsing error', () => {
     const sheet = [
       ['1', '=SUM(A1)'],
     ]
@@ -509,7 +509,7 @@ describe('changing cell content', () => {
     expect(engine.getCellValue(adr('B1'))).toEqualError(detailedError(ErrorType.ERROR, ErrorMessage.ParseError))
   })
 
-  it('update formula cell to parsing error ', () => {
+  it('update formula cell to parsing error', () => {
     const sheet = [
       ['1', '=SUM(A1)'],
     ]
@@ -907,7 +907,6 @@ describe('arrays', () => {
       [undefined, ArrayVertex, ArrayVertex],
     ])
     expect(engine.arrayMapping.arrayMapping.size).toEqual(4)
-    expect(engine.getSheetValues(0))
   })
 
   it('should REF last array', () => {
@@ -931,7 +930,6 @@ describe('arrays', () => {
       [noSpace(), 2, 2, 1, 2],
     ])
     expect(engine.arrayMapping.arrayMapping.size).toEqual(3)
-    expect(engine.getSheetValues(0))
   })
 
   it('should make existing array REF and change cell content to simple value', () => {