Skip to content

Rename the properties of FunctionMetadata and deprecate the old ones#1558

Merged
sequba merged 6 commits into
developfrom
feature/issue-1401
Oct 8, 2025
Merged

Rename the properties of FunctionMetadata and deprecate the old ones#1558
sequba merged 6 commits into
developfrom
feature/issue-1401

Conversation

@sequba

@sequba sequba commented Oct 7, 2025

Copy link
Copy Markdown
Contributor

Context

New properties:

  • sizeOfResultArrayMethod
  • enableArrayArithmeticForArguments

Deprecating:

  • arraySizeMethod
  • arrayFunction

How did you test your changes?

  • unit tests pass
  • new unit tests

Types of changes

  • Breaking change (a fix or a feature because of which an existing functionality doesn't work as expected anymore)
  • New feature or improvement (a non-breaking change that adds functionality)
  • Bug fix (a non-breaking change that fixes an issue)
  • Additional language file, or a change to an existing language file (translations)
  • Change to the documentation

Related issues:

  1. Fixes Rename the properties of FunctionMetadata interface to make them more logical #1401

Checklist:

  • I have reviewed the guidelines about Contributing to HyperFormula and I confirm that my code follows the code style of this project.
  • I have signed the Contributor License Agreement.
  • My change is compliant with the OpenDocument standard.
  • My change is compatible with Microsoft Excel.
  • My change is compatible with Google Sheets.
  • I described my changes in the CHANGELOG.md file.
  • My changes require a documentation update.
  • My changes require a migration guide.

@sequba sequba self-assigned this Oct 7, 2025
@sequba sequba requested a review from qunabu October 7, 2025 19:28
@github-actions

github-actions Bot commented Oct 7, 2025

Copy link
Copy Markdown

Performance comparison of head (758e9af) vs base (ecaff4b)

                                     testName |   base |   head | change
------------------------------------------------------------------------
                                      Sheet A | 492.83 | 495.61 | +0.56%
                                      Sheet B | 161.11 |  161.1 | -0.01%
                                      Sheet T | 141.72 |  141.4 | -0.23%
                                Column ranges | 497.15 | 499.04 | +0.38%
Sheet A:  change value, add/remove row/column |  13.89 |  14.34 | +3.24%
 Sheet B: change value, add/remove row/column | 122.04 | 126.71 | +3.83%
                   Column ranges - add column |  133.4 |  136.9 | +2.62%
                Column ranges - without batch | 407.08 | 436.49 | +7.22%
                        Column ranges - batch | 104.75 | 109.71 | +4.74%

@sequba sequba merged commit ed7a4c9 into develop Oct 8, 2025
31 checks passed
@sequba sequba deleted the feature/issue-1401 branch October 8, 2025 10:29
@codecov

codecov Bot commented Oct 8, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.22%. Comparing base (ecaff4b) to head (758e9af).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1558   +/-   ##
========================================
  Coverage    97.22%   97.22%           
========================================
  Files          169      169           
  Lines        14526    14535    +9     
  Branches      3171     3173    +2     
========================================
+ Hits         14123    14132    +9     
  Misses         396      396           
  Partials         7        7           
Files with missing lines Coverage Δ
src/ArraySize.ts 98.21% <100.00%> (ø)
src/interpreter/FunctionRegistry.ts 99.37% <100.00%> (+0.03%) ⬆️
src/interpreter/plugin/ArrayPlugin.ts 98.64% <100.00%> (ø)
src/interpreter/plugin/FunctionPlugin.ts 99.02% <ø> (ø)
src/interpreter/plugin/LookupPlugin.ts 97.18% <100.00%> (ø)
src/interpreter/plugin/MatrixPlugin.ts 97.88% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants