Skip to content

Add unit tests for auto-updating named expression value on CRUD operations#1563

Merged
sequba merged 1 commit into
developfrom
feature/issue-1498
Oct 15, 2025
Merged

Add unit tests for auto-updating named expression value on CRUD operations#1563
sequba merged 1 commit into
developfrom
feature/issue-1498

Conversation

@sequba

@sequba sequba commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

Context

Adding unit tests to make sure scenario from #1498 works correctly.

How did you test your changes?

unit tests

Related issues:

  1. Fixes [Bug]: Named Expressions don't update when adding rows #1498

Checklist:

  • I have reviewed the guidelines about Contributing to HyperFormula and I confirm that my code follows the code style of this project.
  • I have signed the Contributor License Agreement.
  • My change is compliant with the OpenDocument standard.
  • My change is compatible with Microsoft Excel.
  • My change is compatible with Google Sheets.
  • I described my changes in the CHANGELOG.md file.
  • My changes require a documentation update.
  • My changes require a migration guide.

@github-actions

github-actions Bot commented Oct 15, 2025

Copy link
Copy Markdown

Performance comparison of head (7a08426) vs base (786a26b)

                                     testName |   base |   head | change
------------------------------------------------------------------------
                                      Sheet A | 507.29 | 505.53 | -0.35%
                                      Sheet B | 168.07 | 168.06 | -0.01%
                                      Sheet T | 147.49 | 148.75 | +0.85%
                                Column ranges | 502.86 | 501.45 | -0.28%
Sheet A:  change value, add/remove row/column |  14.78 |  14.05 | -4.94%
 Sheet B: change value, add/remove row/column | 133.88 | 132.59 | -0.96%
                   Column ranges - add column | 137.46 | 137.06 | -0.29%
                Column ranges - without batch | 432.27 | 431.09 | -0.27%
                        Column ranges - batch | 107.62 | 109.74 | +1.97%

@sequba sequba merged commit 348fff0 into develop Oct 15, 2025
31 checks passed
@sequba sequba deleted the feature/issue-1498 branch October 15, 2025 11:55
@codecov

codecov Bot commented Oct 15, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.22%. Comparing base (786a26b) to head (7a08426).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1563   +/-   ##
========================================
  Coverage    97.22%   97.22%           
========================================
  Files          169      169           
  Lines        14536    14536           
  Branches      3174     3174           
========================================
  Hits         14133    14133           
  Misses         396      396           
  Partials         7        7           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant