Skip to content

Feat/remove nodesids map#1597

Merged
sequba merged 5 commits into
handsontable:feature/issue-1602from
Krizz:feat/remove-nodesids-map
Jan 8, 2026
Merged

Feat/remove nodesids map#1597
sequba merged 5 commits into
handsontable:feature/issue-1602from
Krizz:feat/remove-nodesids-map

Conversation

@Krizz

@Krizz Krizz commented Jan 3, 2026

Copy link
Copy Markdown
Contributor

Context

With large datasets like NY 2015 Tree Census nodeIds Map will exceed the maximum size. This will directly store the _graphId to node without the Map.

How did you test your changes?

Imported NY 2015 Street Tree Census dataset into hyperformula

Types of changes

  • Breaking change (a fix or a feature because of which an existing functionality doesn't work as expected anymore)
  • New feature or improvement (a non-breaking change that adds functionality)
  • Bug fix (a non-breaking change that fixes an issue)
  • Additional language file, or a change to an existing language file (translations)
  • Change to the documentation

Checklist:

  • I have reviewed the guidelines about Contributing to HyperFormula and I confirm that my code follows the code style of this project.
  • I have signed the Contributor License Agreement.
  • My change is compliant with the OpenDocument standard.
  • My change is compatible with Microsoft Excel.
  • My change is compatible with Google Sheets.
  • I described my changes in the CHANGELOG.md file.
  • My changes require a documentation update.
  • My changes require a migration guide.

@AMBudnik AMBudnik added the CLA signed Required for PR label Jan 7, 2026
@AMBudnik

AMBudnik commented Jan 7, 2026

Copy link
Copy Markdown
Contributor

Hi @Krizz! 👋

Thank you so much for taking the time to work on this PR and for signing the CLA!

This is a really valuable contribution. I really appreciate the effort you put into this refactoring across multiple files.

@sequba sequba marked this pull request as ready for review January 8, 2026 10:53
@sequba sequba changed the base branch from master to feature/issue-1602 January 8, 2026 10:54
@sequba

sequba commented Jan 8, 2026

Copy link
Copy Markdown
Contributor

@Krizz thank you for your contribution. I'm merging this code to a feature branch to fix failing unit tests. Most likely, it will be included in the upcoming release

@sequba sequba merged commit fcb29f0 into handsontable:feature/issue-1602 Jan 8, 2026
26 of 29 checks passed
@Krizz

Krizz commented Jan 8, 2026

Copy link
Copy Markdown
Contributor Author

@Krizz thank you for your contribution. I'm merging this code to a feature branch to fix failing unit tests. Most likely, it will be included in the upcoming release

@sequba Thank you very much for taking care of this! I was not really looking forward fixing the unit tests and that's why the pull request stayed as draft.

@AMBudnik

Copy link
Copy Markdown
Contributor

Hi @Krizz Thank you again for your contribution.

We just released HyperFormula v3.2.0, which solves this issue. Here's the pull request if you'd like to dig deeper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA signed Required for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants