-
Notifications
You must be signed in to change notification settings - Fork 164
Setup workflow with private tests repo #1616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sequba
merged 27 commits into
develop
from
feature/HF-49_Take-tests-out-from-GitHub-public-repo
Mar 4, 2026
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
33cd1e8
Extend CI For private tests
qunabu 3f6c49b
Extend CI For private tests
qunabu e76fbdf
Extend CI For private tests
qunabu f3afc73
Extend CI For private tests
qunabu 58125f8
Extend CI For private tests
qunabu f4abb97
Extend CI For private tests
qunabu db5fd73
Extend CI For private tests
qunabu 844b2f6
Extend CI For private tests
qunabu d4e3859
Extend CI For private tests
qunabu 040fe72
Extend CI For private tests
qunabu d9668f5
Extend CI For private tests
qunabu c35c61c
Extend CI For private tests
qunabu d346873
Extend CI For private tests
qunabu cf6ab6f
Extend CI For private tests
qunabu bab0951
Extend CI For private tests
qunabu 0f04a10
Add npm script test:fetch-private
sequba 370e3e5
Merge branch 'develop' of github.com:handsontable/hyperformula into f…
sequba 198eee5
Adjust eslintingore
sequba 91501ca
Adjust test.yml GH workflow
sequba c5d69d8
Add performance.yml GH workflow
sequba afc9169
Setup codecov.yml
sequba 5a6fe42
Remove Makefile
sequba 70f2888
Bring back removed npm scripts
sequba 74de850
Update test/README.md
sequba 4529b54
Add setup files for jest and karma
sequba 74d2705
Move codecov.yml to the repository root
sequba 1f45bc4
Fix typo in eslintignore file
sequba File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,6 +15,7 @@ test/_setupFiles/*.js | |
|
|
||
| # Auto-generated directories | ||
| commonjs | ||
| coverage | ||
| dist | ||
| doc | ||
| es | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| name: Performance | ||
| permissions: | ||
| contents: read | ||
| pull-requests: write | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: | ||
| - opened | ||
| - reopened | ||
| - synchronize # the head branch is updated from the base branch, new commits are pushed to the head branch, or the base branch is changed | ||
|
|
||
| jobs: | ||
| performance-test: | ||
| strategy: | ||
| matrix: | ||
| node-version: [ '22' ] | ||
| os: [ 'ubuntu-latest' ] | ||
| name: Test performance | ||
| runs-on: ${{ matrix.os }} | ||
| steps: | ||
| - name: Setup Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@56899e050abffc08c2b3b61f3ec6a79a9dc3223d # https://github.com/actions/setup-node/releases/tag/v1.4.4 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
|
|
||
| - name: (base) Checkout main repository | ||
| uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f # https://github.com/actions/checkout/releases/tag/v2.3.4 | ||
| with: | ||
| ref: ${{ github.event.pull_request.base.sha }} | ||
|
|
||
| - name: Checkout hyperformula-tests repository | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd | ||
| with: | ||
| ssh-key: ${{ secrets.DEPLOY_TOKEN }} | ||
| repository: handsontable/hyperformula-tests | ||
| path: test/hyperformula-tests | ||
|
|
||
| - name: Fetch hyperformula-tests and sync branches | ||
| run: cd test && ./fetch-tests.sh | ||
|
|
||
| - name: (base) Install dependencies | ||
| run: npm ci | ||
|
|
||
| - name: (base) Run performance tests | ||
| run: npm run benchmark:write-to-file base.json | ||
|
cursor[bot] marked this conversation as resolved.
|
||
|
|
||
| - name: (head) Checkout main repository | ||
| uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f # https://github.com/actions/checkout/releases/tag/v2.3.4 | ||
| with: | ||
| clean: false | ||
|
|
||
| - name: (head) Install dependencies | ||
| run: npm ci | ||
|
|
||
| - name: (head) Run performance tests | ||
| run: | | ||
| npm run benchmark:write-to-file head.json | ||
|
|
||
| - name: Compare the results | ||
| run: | | ||
| npm run benchmark:compare-benchmarks base.json head.json performance-report.md | ||
|
|
||
| - name: Publish a comment - header | ||
| uses: marocchino/sticky-pull-request-comment@6804b5ad49d19c10c9ae7cf5057352f7ff333f31 # https://github.com/marocchino/sticky-pull-request-comment/tree/v1.6.0 | ||
| with: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| message: | | ||
| ## Performance comparison of head (${{ github.event.pull_request.head.sha }}) vs base (${{ github.event.pull_request.base.sha }}) | ||
|
|
||
| - name: Publish a comment - performance comparison report | ||
| uses: marocchino/sticky-pull-request-comment@6804b5ad49d19c10c9ae7cf5057352f7ff333f31 # https://github.com/marocchino/sticky-pull-request-comment/tree/v1.6.0 | ||
| with: | ||
| append: true | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| path: performance-report.md | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| codecov: | ||
| require_ci_to_pass: yes | ||
|
|
||
| coverage: | ||
| range: 95..100 | ||
| round: down | ||
| precision: 2 | ||
|
|
||
| comment: | ||
| layout: "reach, diff, flags, files" | ||
| behavior: new | ||
| require_changes: false | ||
| require_base: yes | ||
| require_head: yes | ||
|
cursor[bot] marked this conversation as resolved.
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Performance workflow runs missing script from base checkout
High Severity
The "Fetch hyperformula-tests and sync branches" step runs
./fetch-tests.shagainst the base branch checkout (line 30 usesref: ${{ github.event.pull_request.base.sha }}). Sincetest/fetch-tests.shis a new file introduced in this PR, it won't exist in any base branch that predates this merge, causing the step to fail with "No such file or directory". Thetest.ymlworkflow avoids this because its checkout uses the default ref (the PR's own code).Additional Locations (1)
.github/workflows/performance.yml#L26-L30