docs: fix SSR section framing in React integration guide#1688
Merged
Conversation
✅ Deploy Preview for hyperformula-dev-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Author
|
Verified on preview |
Performance comparison of head (46d1d61) vs base (00e5c73) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1688 +/- ##
========================================
Coverage 97.16% 97.16%
========================================
Files 176 176
Lines 15322 15322
Branches 3356 3356
========================================
Hits 14887 14887
Misses 427 427
Partials 8 8 🚀 New features to boost your workflow:
|
sequba
approved these changes
Jun 2, 2026
GreenFlux
added a commit
that referenced
this pull request
Jun 3, 2026
Brings in two content-only commits that landed on develop after the last sync: - 0e047ee docs: fix SSR section framing in React integration guide (#1688) - 79f2f15 docs: rewrite Vue integration guide around markRaw pattern (#1689) Both touch files we migrated from `docs/guide/` to `docs/src/content/docs/guide/`. Git's rename detection auto-applied the develop-side edits to the new locations — no conflicts. GitHub had flagged the PR as CONFLICTING because its mergeability check hadn't recomputed since develop's last push; pushing this merge clears that flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dynamic(..., { ssr: false })is keeping HyperFormula out of the initial JS bundle sent to the browser, not skipping the server-side render itself (which is already a non-issue sinceuseEffectnever runs on the server).Test Plan
docs/guide/integration-with-react.mdNote
Low Risk
Documentation-only wording change with no runtime or API impact.
Overview
Updates one sentence in the React integration guide’s SSR section so it no longer suggests
dynamic(..., { ssr: false })is mainly about avoiding server render. The text now states the goal is keeping HyperFormula out of the initial JS bundle sent to the browser (still noting the library is a few hundred kB), which matches the earlier point thatuseEffectalready makes the pattern SSR-safe.Reviewed by Cursor Bugbot for commit 46d1d61. Bugbot is set up for automated code reviews on this repo. Configure here.