Fix a problem with being unable to declare renderers/editors with vanilla JS + refine the autoSize warning mechanism.

Author: jansiegel

src/hotTable.tsx

@@ -336,34 +336,41 @@ class HotTable extends React.Component<HotTableProps, {}> {
       newSettings.editor = this.getEditorClass(globalEditorNode);
 
     } else {
-      newSettings.editor = void 0;
+      newSettings.editor = this.props.editor || this.props.settings ? this.props.settings.editor : void 0;
     }
 
     if (globalRendererNode) {
       newSettings.renderer = this.getRendererWrapper(globalRendererNode);
 
     } else {
-      newSettings.renderer = void 0;
+      newSettings.renderer = this.props.renderer || this.props.settings ? this.props.settings.renderer : void 0;
     }
 
     return newSettings;
   }
 
   /**
    * Detect if `autoRowSize` or `autoColumnSize` is defined, and if so, throw an incompatibility warning.
+   *
+   * @param {Handsontable.GridSettings} newGlobalSettings New global settings passed as Handsontable config.
    */
-  displayAutoSizeWarning(): void {
+  displayAutoSizeWarning(newGlobalSettings: Handsontable.GridSettings): void {
     if (this.hotInstance.getPlugin('autoRowSize').enabled || this.hotInstance.getPlugin('autoColumnSize').enabled) {
-      const hotSettings = this.hotInstance.getSettings();
+      const _this = this;
+      const isNativeRenderer = function (renderer, column?) {
+        return column ? (_this.props.columns && _this.props.columns[column] && _this.props.columns[column].renderer === renderer) ||
+          (_this.props.settings && _this.props.settings.columns &&  _this.props.settings.columns[column] && _this.props.settings.columns[column].renderer === renderer) :
+          _this.props.renderer === renderer || _this.props.settings.renderer === renderer;
+      };
       let rendererDefined = false;
 
-      if (hotSettings.renderer) {
+      if (newGlobalSettings.renderer && !isNativeRenderer(newGlobalSettings.renderer)) {
         rendererDefined = true;
       }
 
-      if (!rendererDefined && hotSettings.columns) {
-        for (let i = 0; i < hotSettings.columns.length; i++) {
-          if (hotSettings.columns[i].renderer) {
+      if (!rendererDefined && newGlobalSettings.columns) {
+        for (let i = 0; i < newGlobalSettings.columns.length; i++) {
+          if (newGlobalSettings.columns[i].renderer && !isNativeRenderer(newGlobalSettings.columns[i].renderer, i)) {
             rendererDefined = true;
             break;
           }
@@ -445,8 +452,9 @@ class HotTable extends React.Component<HotTableProps, {}> {
    */
   componentDidMount(): void {
     const hotTableComponent = this;
+    const newGlobalSettings = this.createNewGlobalSettings();
 
-    this.hotInstance = new Handsontable.Core(this.hotElementRef, this.createNewGlobalSettings());
+    this.hotInstance = new Handsontable.Core(this.hotElementRef, newGlobalSettings);
 
     this.hotInstance.addHook('beforeRender', function (isForced) {
       hotTableComponent.handsontableBeforeRender();
@@ -459,7 +467,7 @@ class HotTable extends React.Component<HotTableProps, {}> {
     // `init` missing in Handsontable's type definitions.
     (this.hotInstance as any).init();
 
-    this.displayAutoSizeWarning();
+    this.displayAutoSizeWarning(newGlobalSettings);
   }
 
   /**
@@ -474,7 +482,10 @@ class HotTable extends React.Component<HotTableProps, {}> {
    * Logic performed after the component update.
    */
   componentDidUpdate(): void {
-    this.updateHot(this.createNewGlobalSettings());
+    const newGlobalSettings = this.createNewGlobalSettings();
+    this.updateHot(newGlobalSettings);
+
+    this.displayAutoSizeWarning(newGlobalSettings);
   }
 
   /**