[CI] Add LoRA inference tests#546
Merged
Merged
Conversation
Edenzzzz
had a problem deploying
to
runpod-runners
GitHub Actions
Failure
Edenzzzz
commented
Jul 4, 2025
| output_dtype, | ||
| cast_forward_inputs=False) | ||
|
|
||
| set_mixed_precision_policy(master_dtype=default_dtype, |
Collaborator
Author
There was a problem hiding this comment.
Don't find master_dtype useful, and it also doesn't align with torch
Collaborator
|
It looks like you didn't add the reference videos for lora similarity test.
|
SolitaryThinker
requested changes
Jul 9, 2025
Collaborator
|
seems like there's still some errors in lora inference test. Also the SSIM test shouldn't time out (should finish in ~24 minutes or so) |
Collaborator
Author
|
There's still a bug with FSDP that doesn't allow re-register params for mutli-lora. Reaching out for a solution |
Collaborator
Author
|
Added a note that currently must reload model to use multi-lora |
Collaborator
Author
|
@SolitaryThinker All tests passed. Let's merge this? |
SolitaryThinker
approved these changes
Jul 15, 2025
qimcis
pushed a commit
to qimcis/FastVideo
that referenced
this pull request
Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.