Strip outdated translations#2225
Conversation
Crowdin will fill them in with matching translations, or translators will manually populate them correctly.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2225 +/- ##
============================================
+ Coverage 13.56% 13.60% +0.04%
- Complexity 37839 37930 +91
============================================
Files 2506 2506
Lines 727079 727180 +101
Branches 212396 212414 +18
============================================
+ Hits 98624 98941 +317
+ Misses 595096 594886 -210
+ Partials 33359 33353 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This is still causing existing translations to be removed (and some additional test to be added). See this PR and this Action run The generated PR adds this comment/header chunk: It also continues to delete existing translations (I had to pull it into another diff program because GitHub's default give makes a mess of it):
If there are additional steps required between the generated PR and CrowdIn's state to make this work, please leave them in the comments. |
dotasek
left a comment
There was a problem hiding this comment.
See earlier comments for details. The generated pull request is adding new comments/headers, and deleting existing translations.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |




There are two systems in place for dealing with outdated translations - both in Java code and Crowdin, and they are clashing.
Java code prefixes
!!to outdated translations, which is a new development compared to other translation systems. This works well if you're translating the.pofile by hand. If you import it into Crowdin though, that causes issues as it has it's own mechanisms for tracking updated source strings, matching them intelligently, and notifying translators of what actually needs translating.The proposal here will leave the
!!system as it is unless we need to interact with Crowdin, where we'll remove the outdated translations and let Crowdin's Translation Memory and other tools do their job.