Skip to content

Strip outdated translations#2225

Closed
vadi2 wants to merge 1 commit into
hapifhir:masterfrom
vadi2:adjust-crowdin-workflow
Closed

Strip outdated translations#2225
vadi2 wants to merge 1 commit into
hapifhir:masterfrom
vadi2:adjust-crowdin-workflow

Conversation

@vadi2
Copy link
Copy Markdown
Contributor

@vadi2 vadi2 commented Oct 29, 2025

There are two systems in place for dealing with outdated translations - both in Java code and Crowdin, and they are clashing.

Java code prefixes !! to outdated translations, which is a new development compared to other translation systems. This works well if you're translating the .po file by hand. If you import it into Crowdin though, that causes issues as it has it's own mechanisms for tracking updated source strings, matching them intelligently, and notifying translators of what actually needs translating.

The proposal here will leave the !! system as it is unless we need to interact with Crowdin, where we'll remove the outdated translations and let Crowdin's Translation Memory and other tools do their job.

Crowdin will fill them in with matching translations, or translators will manually populate them correctly.
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 13.60%. Comparing base (3fef23b) to head (64e2541).
⚠️ Report is 10951 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2225      +/-   ##
============================================
+ Coverage     13.56%   13.60%   +0.04%     
- Complexity    37839    37930      +91     
============================================
  Files          2506     2506              
  Lines        727079   727180     +101     
  Branches     212396   212414      +18     
============================================
+ Hits          98624    98941     +317     
+ Misses       595096   594886     -210     
+ Partials      33359    33353       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dotasek
Copy link
Copy Markdown
Collaborator

dotasek commented Oct 30, 2025

This is still causing existing translations to be removed (and some additional test to be added).

See this PR and this Action run

The generated PR adds this comment/header chunk:

msgid ""
msgstr ""
"Plural-Forms: nplurals=2; plural=(n > 1);\n"
"X-Crowdin-Project: orghl7fhircore\n"
"X-Crowdin-Project-ID: 792848\n"
"X-Crowdin-Language: fr\n"
"X-Crowdin-File: /org.hl7.fhir.utilities/src/main/resources/source/rendering-phrases-en.po\n"
"X-Crowdin-File-ID: 236\n"
"Project-Id-Version: orghl7fhircore\n"
"Content-Type: text/plain; charset=UTF-8\n"
"Language-Team: French\n"
"Language: fr_FR\n"
"PO-Revision-Date: 2025-10-30 18:26\n"

It also continues to delete existing translations (I had to pull it into another diff program because GitHub's default give makes a mess of it):

Screenshot 2025-10-30 at 3 56 28 PM Screenshot 2025-10-30 at 3 56 14 PM Screenshot 2025-10-30 at 3 55 51 PM Screenshot 2025-10-30 at 3 53 08 PM

If there are additional steps required between the generated PR and CrowdIn's state to make this work, please leave them in the comments.

Copy link
Copy Markdown
Collaborator

@dotasek dotasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See earlier comments for details. The generated pull request is adding new comments/headers, and deleting existing translations.

@stale
Copy link
Copy Markdown

stale Bot commented Apr 25, 2026

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the wontfix This will not be worked on label Apr 25, 2026
@stale stale Bot closed this May 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wontfix This will not be worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants