Skip to content

possible fix for #2138#2279

Open
oliveregger wants to merge 1 commit into
hapifhir:masterfrom
ahdis:oe_ext5slicing
Open

possible fix for #2138#2279
oliveregger wants to merge 1 commit into
hapifhir:masterfrom
ahdis:oe_ext5slicing

Conversation

@oliveregger
Copy link
Copy Markdown
Contributor

we got noted in matchbox ahdis/matchbox#424 that r5 extensions in r4 are throwing an error when validating against a profile where the r5 extensions are listed as discriminators. after a second validation in the same context the problem disappeared. we tracked it down that the xversion where not considered inside the slicing, attached a fix which helped solved our problem and i assume it should also fix #2138

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 13.55%. Comparing base (93f5c59) to head (15ee386).
⚠️ Report is 29 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2279      +/-   ##
============================================
- Coverage     13.64%   13.55%   -0.10%     
+ Complexity    38036    37736     -300     
============================================
  Files          2517     2495      -22     
  Lines        728379   727970     -409     
  Branches     212616   212500     -116     
============================================
- Hits          99418    98672     -746     
- Misses       595484   595890     +406     
+ Partials      33477    33408      -69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@grahamegrieve
Copy link
Copy Markdown
Collaborator

do we have a test case that this fixes?

@Boereck
Copy link
Copy Markdown
Contributor

Boereck commented Feb 17, 2026

Is it expected to add a test case to the fhir-test-cases repository? I think I could cook up a condensed example during the next days based on the problem I reported in #2138 and create a PR to the aforementioned repository.

@grahamegrieve
Copy link
Copy Markdown
Collaborator

yes, need a test case there. In the validation tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

InstanceValidator: Cross-version extensions cannot be used as discriminator in slices

3 participants