fix: fix ci and lint

Author: hpsing

.github/workflows/ci.yml

@@ -16,7 +16,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: [ubuntu-latest, macos-latest, windows-latest]
+        os: [ubuntu-latest, macos-latest]
 
     steps:
       - uses: actions/checkout@v4

.github/workflows/release.yml

@@ -36,5 +36,4 @@ jobs:
           # Optional — set to publish to each distribution channel.
           # If a secret is absent the channel is skipped automatically.
           HOMEBREW_TAP_TOKEN: ${{ secrets.HOMEBREW_TAP_TOKEN || '' }}
-          SCOOP_BUCKET_TOKEN: ${{ secrets.SCOOP_BUCKET_TOKEN || '' }}
           AUR_KEY: ${{ secrets.AUR_KEY || '' }}

.goreleaser.yaml

@@ -21,18 +21,13 @@ builds:
     goos:
       - linux
       - darwin
-      - windows
     goarch:
       - amd64
       - arm64
       - arm        # linux/arm (armv7 — Raspberry Pi, embedded)
     goarm:
       - "7"
     ignore:
-      - goos: windows
-        goarch: arm64
-      - goos: windows
-        goarch: arm
       - goos: darwin
         goarch: arm
 
@@ -46,9 +41,6 @@ archives:
       {{- else if eq .Arch "arm64" }}arm64
       {{- else if eq .Arch "arm" }}armv7
       {{- else }}{{ .Arch }}{{ end }}
-    format_overrides:
-      - goos: windows
-        format: zip
     files:
       - LICENSE
       - README.md
@@ -82,6 +74,8 @@ changelog:
       order: 999
 
 # ── macOS / Linux: Homebrew ────────────────────────────────────────────────
+# Binaries are uploaded to GitHub Releases; GoReleaser pushes the formula to
+# the tap repo so `brew install hapiio/tap/git-profile` resolves correctly.
 brews:
   - repository:
       owner: hapiio
@@ -104,23 +98,6 @@ brews:
       zsh_completion.install Utils.safe_popen_read(bin/"git-profile", "completion", "zsh") => "_git-profile"
       fish_completion.install Utils.safe_popen_read(bin/"git-profile", "completion", "fish") => "git-profile.fish"
 
-# ── Windows: Scoop ────────────────────────────────────────────────────────
-# Skipped automatically when SCOOP_BUCKET_TOKEN secret is not configured.
-scoops:
-  - repository:
-      owner: hapiio
-      name: scoop-bucket
-      token: "{{ .Env.SCOOP_BUCKET_TOKEN }}"
-    commit_author:
-      name: goreleaserbot
-      email: bot@goreleaser.com
-    commit_message_template: "Scoop update for {{ .ProjectName }} version {{ .Tag }}"
-    directory: bucket
-    homepage: "https://github.com/hapiio/git-profile"
-    description: "Manage multiple git identity profiles with a single command"
-    license: MIT
-    skip_upload: "{{ if not .Env.SCOOP_BUCKET_TOKEN }}true{{ end }}"
-
 # ── Arch Linux: AUR ──────────────────────────────────────────────────────
 aurs:
   - name: git-profile-bin

CONTRIBUTING.md

@@ -221,13 +221,12 @@ This triggers `.github/workflows/release.yml`, which:
 
 1. Runs the full test suite
 2. Builds binaries for all platforms (linux/amd64, linux/arm64, linux/armv7,
-   darwin/amd64, darwin/arm64, windows/amd64)
+   darwin/amd64, darwin/arm64)
 3. Creates GitHub Release with checksums
-4. Publishes archives (`.tar.gz` / `.zip`)
+4. Publishes archives (`.tar.gz`)
 5. Publishes `.deb` and `.rpm` packages
 6. Updates the Homebrew formula (macOS + Linux)
-7. Updates the Scoop bucket (Windows) — if `SCOOP_BUCKET_TOKEN` is set
-8. Publishes to AUR (Arch Linux) — if `AUR_KEY` is set
+7. Publishes to AUR (Arch Linux) — if `AUR_KEY` is set
 
 ---
 
@@ -238,7 +237,6 @@ Add these under **Settings → Secrets and variables → Actions**:
 | Secret | Required | Description |
 |---|---|---|
 | `HOMEBREW_TAP_TOKEN` | Recommended | PAT with `repo` write access to `hapiio/homebrew-tap` |
-| `SCOOP_BUCKET_TOKEN` | Optional | PAT with `repo` write access to `hapiio/scoop-bucket` |
 | `AUR_KEY` | Optional | Base64-encoded ed25519 private key registered on AUR |
 | `CODECOV_TOKEN` | Optional | Codecov upload token for coverage reporting |
 

README.md

@@ -24,7 +24,7 @@ never accidentally push a personal commit with your work email again.
 - **Interactive picker** — fuzzy-free numbered menu when you can't remember the ID
 - **Import existing identity** — bootstrap a profile from your current git config in one command
 - **Edit, rename, remove** — full profile lifecycle management
-- **Shell completions** — bash, zsh, fish, and PowerShell
+- **Shell completions** — bash, zsh, and fish
 - **Zero runtime dependencies** — single static binary, no runtime required
 
 ---
@@ -173,10 +173,7 @@ Resolution order:
 
 Profiles are stored in a JSON file at:
 
-| Platform      | Path                                                                                         |
-| ------------- | -------------------------------------------------------------------------------------------- |
-| macOS / Linux | `$XDG_CONFIG_HOME/git-profile/config.json` (defaults to `~/.config/git-profile/config.json`) |
-| Windows       | `%AppData%\git-profile\config.json`                                                          |
+Profiles are stored at `$XDG_CONFIG_HOME/git-profile/config.json` (defaults to `~/.config/git-profile/config.json`).
 
 Override the path with `--config`:
 
@@ -220,9 +217,6 @@ git-profile completion zsh > "${fpath[1]}/_git-profile"
 
 # fish
 git-profile completion fish > ~/.config/fish/completions/git-profile.fish
-
-# PowerShell
-git-profile completion powershell | Out-String | Invoke-Expression
 ```
 
 ---

internal/config/config.go

@@ -92,7 +92,7 @@ func (m *Manager) Load() (*Config, error) {
 		}
 		return nil, fmt.Errorf("opening config: %w", err)
 	}
-	defer f.Close()
+	defer f.Close() //nolint:errcheck // read-only file; close error is inconsequential
 
 	if err := json.NewDecoder(f).Decode(cfg); err != nil {
 		return nil, fmt.Errorf("parsing config %s: %w", m.path, err)
@@ -118,18 +118,18 @@ func (m *Manager) Save(cfg *Config) error {
 	enc := json.NewEncoder(f)
 	enc.SetIndent("", "  ")
 	if encErr := enc.Encode(cfg); encErr != nil {
-		f.Close()
-		os.Remove(tmp)
+		f.Close()           //nolint:errcheck // already handling encode error
+		os.Remove(tmp)      //nolint:errcheck // best-effort cleanup
 		return fmt.Errorf("encoding config: %w", encErr)
 	}
 
 	if err := f.Close(); err != nil {
-		os.Remove(tmp)
+		os.Remove(tmp) //nolint:errcheck // best-effort cleanup
 		return fmt.Errorf("flushing config: %w", err)
 	}
 
 	if err := os.Rename(tmp, m.path); err != nil {
-		os.Remove(tmp)
+		os.Remove(tmp) //nolint:errcheck // best-effort cleanup
 		return fmt.Errorf("saving config: %w", err)
 	}
 

internal/ui/ui.go

@@ -28,7 +28,7 @@ var (
 	Bold    = lipgloss.NewStyle().Bold(true)
 
 	// ActiveMarker is the bullet shown next to the current profile.
-	ActiveMarker = Success.Copy().Bold(true).Render("●")
+	ActiveMarker = lipgloss.NewStyle().Foreground(colorSuccess).Bold(true).Render("●")
 )
 
 // Successf prints a styled success message to stdout.