refactor: pass question to buid project method

Author: sfelix-martins

src/__tests__/actions/add.action.spec.ts

@@ -3,7 +3,6 @@ import emoji from 'node-emoji';
 
 import { AddAction } from '../../actions/add.action';
 import * as projectBuilder from '../../core/project/builder/project.builder';
-import * as projectQuestionsBuilder from '../../core/project/builder/questions.builder';
 import { ProjectRepository } from '../../core/project/persistence/repository';
 import { Project } from '../../core/project/project.entity';
 import { OpenVSCode } from '../../core/project/tasks/open-editor/vscode.task';
@@ -15,29 +14,58 @@ jest.mock('../../core/project/builder/questions.builder');
 const buildProject = projectBuilder.buildProject as jest.MockedFunction<
   typeof projectBuilder.buildProject
 >;
-const buildProjectQuestions = projectQuestionsBuilder.buildProjectQuestions as jest.MockedFunction<
-  typeof projectQuestionsBuilder.buildProjectQuestions
->;
 
 describe('Add action', () => {
   describe('Setup', () => {
-    it('should return a function calling handle with inputs', () => {
-      const action = new AddAction({} as ProjectRepository);
-      action.handle = jest.fn();
-      const setup = action.setup();
+    describe('When occurr some error handling action', () => {
+      it('should exit process with code 1', async () => {
+        global.process.exit = jest.fn() as any;
+        const action = new AddAction({} as ProjectRepository);
+        action.handle = jest.fn().mockRejectedValue(new Error());
+
+        const setup = action.setup();
+
+        const path = '/var/www/html';
+        const alias = 'fun';
+
+        const command = { path };
+
+        await setup(alias, command);
+
+        expect(action.handle).toHaveBeenCalledTimes(1);
+        expect(action.handle).toHaveBeenCalledWith([
+          { name: 'alias', value: alias },
+          { name: 'path', value: path },
+        ]);
+
+        expect(process.exit).toHaveBeenCalledTimes(1);
+        expect(process.exit).toHaveBeenCalledWith(1);
+      });
+    });
+
+    describe('When handle with success', () => {
+      it('should return a function calling handle with inputs', () => {
+        global.process.exit = jest.fn() as any;
+
+        const action = new AddAction({} as ProjectRepository);
+        action.handle = jest.fn();
+        const setup = action.setup();
+
+        const path = '/var/www/html';
+        const alias = 'fun';
 
-      const path = '/var/www/html';
-      const alias = 'fun';
+        const command = { path };
 
-      const command = { path };
+        setup(alias, command);
 
-      setup(alias, command);
+        expect(action.handle).toHaveBeenCalledTimes(1);
+        expect(action.handle).toHaveBeenCalledWith([
+          { name: 'alias', value: alias },
+          { name: 'path', value: path },
+        ]);
 
-      expect(action.handle).toHaveBeenCalledTimes(1);
-      expect(action.handle).toHaveBeenCalledWith([
-        { name: 'alias', value: alias },
-        { name: 'path', value: path },
-      ]);
+        expect(process.exit).not.toHaveBeenCalled();
+      });
     });
   });
 
@@ -133,14 +161,12 @@ describe('Add action', () => {
 
           describe('When project not exists', () => {
             const path = `${__dirname}/../fixtures`;
-            const questions = ['fake-questions'];
             let action: AddAction;
 
             describe('When persist project with success', () => {
               let project: Project;
               beforeAll(async () => {
                 global.console.log = jest.fn();
-                buildProjectQuestions.mockReturnValue(questions);
 
                 repositoryMock.create.mockResolvedValue(true);
 
@@ -160,16 +186,8 @@ describe('Add action', () => {
                 project = projectDefinitionsFactory();
               });
 
-              it('should build questions with project alias', () => {
-                expect(buildProjectQuestions).toHaveBeenCalled();
-              });
-
               it('should build project with build project questions', () => {
-                expect(buildProject).toHaveBeenCalledWith(
-                  alias,
-                  path,
-                  questions,
-                );
+                expect(buildProject).toHaveBeenCalledWith(alias, path);
               });
 
               it('should persist the built project', () => {

src/__tests__/core/project/builder/project.builder.spec.ts

@@ -1,7 +1,6 @@
 import * as inquirer from 'inquirer';
 
 import { buildProject } from '../../../../core/project/builder/project.builder';
-import { BuildProjectQuestionCollection } from '../../../../core/project/builder/questions.builder';
 import { Project } from '../../../../core/project/project.entity';
 import { OpenVSCode } from '../../../../core/project/tasks/open-editor/vscode.task';
 
@@ -16,14 +15,12 @@ describe('Build project', () => {
 
     let builtProject: Project;
     beforeAll(async () => {
-      const questions = {} as BuildProjectQuestionCollection;
-
       const answers = {
         tasks: ['open-vscode'],
       };
 
       prompt.mockResolvedValue(answers);
-      builtProject = await buildProject(alias, path, questions);
+      builtProject = await buildProject(alias, path);
     });
 
     it('should built project with open-vscode action', () => {

src/actions/abstract.action.ts

@@ -1,7 +1,7 @@
 import { Input } from '../commands/command.input';
 
 export abstract class AbstractAction {
-  setup(this: AbstractAction): (...args: any[]) => void {
+  setup(this: AbstractAction): (...args: any[]) => Promise<void> {
     return async (...args: any[]) => {
       const inputs = this.mountInputs(...args);
 

src/actions/add.action.ts

@@ -4,7 +4,6 @@ import * as fs from 'fs';
 
 import { Input } from '../commands/command.input';
 import { buildProject } from '../core/project/builder/project.builder';
-import { buildProjectQuestions } from '../core/project/builder/questions.builder';
 import { ProjectRepository } from '../core/project/persistence/repository';
 import {
   ADD_ACTION_SUCCESS,
@@ -29,13 +28,10 @@ export class AddAction extends AbstractAction {
 
   public async handle(inputs: Input[]) {
     const projectAlias = getProjectAlias(inputs);
-    const projectPath = this._getProjectPath(inputs);
-
     await this._ensureProjectDoesNotExists(projectAlias);
 
-    const questions = buildProjectQuestions();
-
-    const project = await buildProject(projectAlias, projectPath, questions);
+    const projectPath = this._getProjectPath(inputs);
+    const project = await buildProject(projectAlias, projectPath);
 
     await this.repository.create(project);
 
@@ -46,9 +42,9 @@ export class AddAction extends AbstractAction {
   private async _ensureProjectDoesNotExists(
     projectAlias: string,
   ): Promise<void> {
-    const existentProject = await this.repository.findOne(projectAlias);
+    const project = await this.repository.findOne(projectAlias);
 
-    if (!!existentProject) {
+    if (!!project) {
       const errorMessage = PROJECT_ALREADY_EXISTS(projectAlias);
 
       console.error(errorMessage);

src/core/project/builder/project.builder.ts

@@ -2,13 +2,14 @@ import * as inquirer from 'inquirer';
 
 import { Project } from '../project.entity';
 import { createTask } from '../tasks/task.factory';
-import { BuildProjectQuestionCollection } from './questions.builder';
+import { buildProjectQuestions } from './questions.builder';
 
 export async function buildProject(
   alias: string,
   path: string,
-  questions: BuildProjectQuestionCollection,
 ): Promise<Project> {
+  const questions = buildProjectQuestions();
+
   const answers = await inquirer.prompt(questions);
 
   const project = new Project(alias, path);