Skip to content

Fix .s16/.f32/.r30 loading on numpy >= 2.0 #1049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
happycube merged 1 commit into from
Jul 17, 2026
Merged

Fix .s16/.f32/.r30 loading on numpy >= 2.0 #1049

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lddecode/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,11 +290,11 @@ def load_unpacked_data(infile, sample, readlen, sampletype):
inbuf = infile.read(readlen * samplelength)

if sampletype == 4:
indata = np.fromstring(inbuf, "float32", len(inbuf) // 4) * 32768
indata = np.frombuffer(inbuf, "float32", len(inbuf) // 4) * 32768
elif sampletype == 3:
indata = np.frombuffer(inbuf, "uint16", len(inbuf) // 2)
elif sampletype == 2:
indata = np.fromstring(inbuf, "int16", len(inbuf) // 2)
indata = np.frombuffer(inbuf, "int16", len(inbuf) // 2)
else:
# NOTE(oln): Can probably use frombuffer for other variants too but
# didn't have any samples to test with.
Expand Down Expand Up @@ -334,7 +334,7 @@ def load_packed_data_3_32(infile, sample, readlen):
needed = int(np.ceil(readlen * 3 / 4) * 4) + 4

inbuf = infile.read(needed)
indata = np.fromstring(inbuf, "uint32", len(inbuf) // 4)
indata = np.frombuffer(inbuf, "uint32", len(inbuf) // 4)

if len(indata) < needed:
return None
Expand Down
Loading