MINOR: global: add takeover_other_tg_connections to tune options

Author: mjuraga

config-parser/section-parsers.go

@@ -359,6 +359,7 @@ func (p *configParser) getGlobalParser() *Parsers { //nolint: maintidx
 	addParser(parser, &sequence, &simple.Number{Name: "tune.ssl.ocsp-update.maxdelay"})
 	addParser(parser, &sequence, &simple.Number{Name: "tune.ssl.ocsp-update.mindelay"})
 	addParser(parser, &sequence, &simple.Number{Name: "tune.stick-counters"})
+	addParser(parser, &sequence, &simple.Word{Name: "tune.takeover-other-tg-connections"})
 	addParser(parser, &sequence, &simple.Size{Name: "tune.vars.global-max-size"})
 	addParser(parser, &sequence, &simple.Size{Name: "tune.vars.proc-max-size"})
 	addParser(parser, &sequence, &simple.Size{Name: "tune.vars.reqres-max-size"})

configuration/global.go

@@ -1530,6 +1530,15 @@ func parseTuneOptions(p parser.Parser) (*models.TuneOptions, error) { //nolint:g
 		options.StickCounters = intPOption
 	}
 
+	strOption, err = parseStringOption(p, "tune.takeover-other-tg-connections")
+	if err != nil {
+		return nil, err
+	}
+	if strOption != "" {
+		isEmpty = false
+		options.TakeoverOtherTgConnections = strOption
+	}
+
 	strOption, err = parseOnOffOption(p, "tune.fd.edge-triggered")
 	if err != nil {
 		return nil, err
@@ -3833,6 +3842,9 @@ func serializeTuneOptions(p parser.Parser, options *models.TuneOptions, configOp
 	if err := serializeInt64POption(p, "tune.stick-counters", options.StickCounters); err != nil {
 		return err
 	}
+	if err := serializeStringOption(p, "tune.takeover-other-tg-connections", options.TakeoverOtherTgConnections); err != nil {
+		return err
+	}
 	if err := serializeOnOffOption(p, "tune.fd.edge-triggered", options.FdEdgeTriggered); err != nil {
 		return err
 	}

models/tune_options.go

@@ -1695,6 +1695,12 @@ definitions:
         type: integer
         x-display-name: Number of stick-counters
         x-nullable: true
+      takeover_other_tg_connections:
+        enum:
+          - none
+          - restricted
+          - full
+        type: string
     type: object
   tune_quic_options:
     properties:

models/tune_options_compare.go

@@ -648,6 +648,9 @@ tune_options:
       type: integer
       x-display-name: Number of stick-counters
       x-nullable: true
+    takeover_other_tg_connections:
+      type: string
+      enum: ["none", "restricted", "full"]
     fd_edge_triggered:
       type: string
       enum: [enabled, disabled]

models/tune_options_compare_test.go

@@ -115,6 +115,7 @@ global
   tune.ssl.ocsp-update.maxdelay 48
   tune.ssl.ocsp-update.mindelay 49
   tune.stick-counters 50
+  tune.takeover-other-tg-connections none
   tune.vars.global-max-size 51
   tune.vars.proc-max-size 52
   tune.vars.reqres-max-size 53

specification/build/haproxy_spec.yaml

@@ -327,7 +327,8 @@
             "ring_queues": 8,
             "runqueue_depth": 38,
             "sched_low_latency": "enabled",
-            "stick_counters": 50
+            "stick_counters": 50,
+            "takeover_other_tg_connections": "none"
         },
         "tune_ssl_default_dh_param": 45,
         "uid": 1,

specification/models/configuration/global.yaml

@@ -183,17 +183,18 @@ func getGlobalBase() models.GlobalBase {
 			OcspUpdateMinDelay: misc.Int64P(49),
 		},
 		TuneOptions: &models.TuneOptions{
-			DisableZeroCopyForwarding: true,
-			EventsMaxEventsAtOnce:     50,
-			H1ZeroCopyFwdRecv:         "disabled",
-			H1ZeroCopyFwdSend:         "disabled",
-			H2ZeroCopyFwdSend:         "disabled",
-			MaxChecksPerThread:        misc.Int64P(20),
-			NotsentLowatClient:        misc.Int64P(10),
-			NotsentLowatServer:        misc.Int64P(20),
-			PeersMaxUpdatesAtOnce:     100,
-			PtZeroCopyForwarding:      "disabled",
-			StickCounters:             misc.Int64P(50),
+			DisableZeroCopyForwarding:  true,
+			EventsMaxEventsAtOnce:      50,
+			H1ZeroCopyFwdRecv:          "disabled",
+			H1ZeroCopyFwdSend:          "disabled",
+			H2ZeroCopyFwdSend:          "disabled",
+			MaxChecksPerThread:         misc.Int64P(20),
+			NotsentLowatClient:         misc.Int64P(10),
+			NotsentLowatServer:         misc.Int64P(20),
+			PeersMaxUpdatesAtOnce:      100,
+			PtZeroCopyForwarding:       "disabled",
+			StickCounters:              misc.Int64P(50),
+			TakeoverOtherTgConnections: "restricted",
 		},
 		HTTPClientOptions: &models.HTTPClientOptions{
 			ResolversDisabled: "disabled",