BUG/MINOR: userlists: fix ordering of users in userlist serialization

Author: mjuraga

configuration/structured_userlists.go

@@ -17,6 +17,7 @@ package configuration
 
 import (
 	"fmt"
+	"sort"
 
 	"github.com/go-openapi/strfmt"
 	parser "github.com/haproxytech/client-native/v6/config-parser"
@@ -153,12 +154,25 @@ func serializeUserlistSection(a StructuredToParserArgs, u *models.Userlist) erro
 	if err != nil {
 		return err
 	}
-	for _, user := range u.Users {
+
+	userNames := make([]string, 0, len(u.Users))
+	for name := range u.Users {
+		userNames = append(userNames, name)
+	}
+	sort.Strings(userNames)
+	for _, username := range userNames {
+		user := u.Users[username]
 		if err = p.Insert(parser.UserList, u.Name, "user", SerializeUser(user), -1); err != nil {
 			return a.HandleError(user.Username, "userlist", u.Name, a.TID, a.TID == "", err)
 		}
 	}
-	for _, group := range u.Groups {
+	groupNames := make([]string, 0, len(u.Groups))
+	for name := range u.Groups {
+		groupNames = append(groupNames, name)
+	}
+	sort.Strings(groupNames)
+	for _, name := range groupNames {
+		group := u.Groups[name]
 		if err = p.Insert(parser.UserList, u.Name, "group", SerializeGroup(group), -1); err != nil {
 			return a.HandleError(group.Name, "userlist", u.Name, a.TID, a.TID == "", err)
 		}