Skip to content

Commit c845f73

Browse files
committed
BUG/MINOR: specification: acme: drop RSA-only bits minimum
The bits field on acme providers is documented as the number of bits used to generate an RSA key, but the schema enforced minimum: 1024 unconditionally. HAProxy ignores bits when keytype is ECDSA (curves is used instead), so the validation incorrectly blocked configurations that set bits to ECDSA-typical sizes like 256 or 384. Drop the minimum and clarify the description so the field's role across both key types is unambiguous.
1 parent ab190db commit c845f73

3 files changed

Lines changed: 3 additions & 23 deletions

File tree

models/acme_provider.go

Lines changed: 1 addition & 19 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

specification/build/haproxy_spec.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12136,8 +12136,7 @@ definitions:
1213612136
type: string
1213712137
description: List of variables passed to the dns-01 provider (typically API keys)
1213812138
bits:
12139-
description: Number of bits to generate an RSA certificate
12140-
minimum: 1024
12139+
description: Number of bits used when generating an RSA certificate. Ignored when keytype is ECDSA (curves is used instead).
1214112140
type: integer
1214212141
x-nullable: true
1214312142
x-omitempty: true

specification/models/configuration/acme.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,7 @@ acme:
2323
type: string
2424
bits:
2525
type: integer
26-
description: Number of bits to generate an RSA certificate
27-
minimum: 1024
26+
description: Number of bits used when generating an RSA certificate. Ignored when keytype is ECDSA (curves is used instead).
2827
x-omitempty: true
2928
x-nullable: true
3029
challenge:

0 commit comments

Comments
 (0)