MINOR: add support for tune.lua.bool-sample-conversion

Author: oliwer

config-parser/section-parsers.go

@@ -311,6 +311,7 @@ func (p *configParser) getGlobalParser() *Parsers { //nolint: maintidx
 	addParser(parser, &sequence, &simple.Time{Name: "tune.idletimer"})
 	addParser(parser, &sequence, &simple.String{Name: "tune.listener.default-shards"})
 	addParser(parser, &sequence, &simple.OnOff{Name: "tune.listener.multi-queue"})
+	addParser(parser, &sequence, &simple.Word{Name: "tune.lua.bool-sample-conversion"})
 	addParser(parser, &sequence, &simple.Number{Name: "tune.lua.forced-yield"})
 	addParser(parser, &sequence, &simple.Number{Name: "tune.lua.maxmem"})
 	addParser(parser, &sequence, &simple.Time{Name: "tune.lua.session-timeout"})

configuration/global.go

@@ -1819,9 +1819,20 @@ func parseTuneBufferOptions(p parser.Parser) (*models.TuneBufferOptions, error)
 func parseTuneLuaOptions(p parser.Parser) (*models.TuneLuaOptions, error) {
 	var intOption int64
 	var intPOption *int64
+	var strOption string
 	var err error
 	options := &models.TuneLuaOptions{}
 	isEmpty := true
+
+	strOption, err = parseStringOption(p, "tune.lua.bool-sample-conversion")
+	if err != nil {
+		return nil, err
+	}
+	if strOption != "" {
+		isEmpty = false
+		options.BoolSampleConversion = strOption
+	}
+
 	intOption, err = parseInt64Option(p, "tune.lua.forced-yield")
 	if err != nil {
 		return nil, err
@@ -1840,7 +1851,7 @@ func parseTuneLuaOptions(p parser.Parser) (*models.TuneLuaOptions, error) {
 		isEmpty = false
 	}
 
-	strOption, err := parseOnOffOption(p, "tune.lua.log.loggers")
+	strOption, err = parseOnOffOption(p, "tune.lua.log.loggers")
 	if err != nil {
 		return nil, err
 	}
@@ -3582,6 +3593,9 @@ func serializeTuneLuaOptions(p parser.Parser, options *models.TuneLuaOptions, co
 	if options == nil {
 		options = &models.TuneLuaOptions{}
 	}
+	if err := serializeStringOption(p, "tune.lua.bool-sample-conversion", options.BoolSampleConversion); err != nil {
+		return err
+	}
 	if err := serializeTimeoutOption(p, "tune.lua.burst-timeout", options.BurstTimeout, configOptions); err != nil {
 		return err
 	}

models/tune_lua_options.go

@@ -1797,6 +1797,11 @@ definitions:
     type: object
   tune_lua_options:
     properties:
+      bool_sample_conversion:
+        enum:
+          - normal
+          - pre-3.1-bug
+        type: string
       burst_timeout:
         minimum: 0
         type: integer

models/tune_lua_options_compare.go

@@ -770,6 +770,9 @@ tune_ssl_options:
 tune_lua_options:
   type: object
   properties:
+    bool_sample_conversion:
+      type: string
+      enum: ["normal", "pre-3.1-bug"]
     forced_yield:
       type: integer
       x-display-name: Lua Forced Yield

models/tune_lua_options_compare_test.go

@@ -43,8 +43,6 @@ global
   cpu-set drop-core 5-9
   lua-prepend-path /usr/share/haproxy-lua/?/init.lua
   lua-prepend-path /usr/share/haproxy-lua/?.lua cpath
-	lua-load /etc/foo.lua
-	lua-load /etc/bar.lua
   h1-case-adjust-file /etc/headers.adjust
   h1-case-adjust host Host
   h1-case-adjust content-type Content-Type
@@ -77,6 +75,7 @@ global
   tune.idletimer 22
   tune.listener.default-shards by-process
   tune.listener.multi-queue on
+  tune.lua.bool-sample-conversion normal
   tune.lua.forced-yield 23
   tune.lua.log.loggers on
   tune.lua.log.stderr auto
@@ -137,6 +136,8 @@ global
   busy-polling
   max-spread-checks 1ms
   close-spread-time 1s
+  lua-load /etc/foo.lua
+	lua-load /etc/bar.lua
   maxconnrate 2
   maxcomprate 3
   maxcompcpuusage 4

specification/build/haproxy_spec.yaml

@@ -398,6 +398,7 @@
             "bufsize_small": 8192
         },
         "tune_lua_options": {
+            "bool_sample_conversion": "normal",
             "burst_timeout": 205,
             "forced_yield": 23,
             "log_loggers": "enabled",