Skip to content

Commit e34b8ab

Browse files
committed
TEST/MINOR: fix go vet errors
1 parent 06ca61b commit e34b8ab

258 files changed

Lines changed: 3293 additions & 3293 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

cmd/struct_equal_generator/test.tmpl

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,15 @@ func Test{{$.Name}}{{.}}(t *testing.T) {
99
var result {{$.Name}}
1010
err := faker.FakeData(&sample)
1111
if err != nil {
12-
t.Errorf(err.Error())
12+
t.Error(err.Error())
1313
}
1414
byteJSON, err := json.Marshal(sample)
1515
if err != nil {
16-
t.Errorf(err.Error())
16+
t.Error(err.Error())
1717
}
1818
err = json.Unmarshal(byteJSON, &result)
1919
if err != nil {
20-
t.Errorf(err.Error())
20+
t.Error(err.Error())
2121
}
2222

2323
samples = append(samples, struct {
@@ -36,11 +36,11 @@ func Test{{$.Name}}{{.}}(t *testing.T) {
3636
json := jsoniter.ConfigCompatibleWithStandardLibrary
3737
a, err := json.Marshal(&sample.a)
3838
if err != nil {
39-
t.Errorf(err.Error())
39+
t.Error(err.Error())
4040
}
4141
b, err := json.Marshal(&sample.b)
4242
if err != nil {
43-
t.Errorf(err.Error())
43+
t.Error(err.Error())
4444
}
4545
{{- if eq . "Equal" }}
4646
t.Errorf("Expected {{$.Name}} to be equal, but it is not %s %s", a, b)
@@ -64,11 +64,11 @@ func Test{{$.Name}}{{.}}False(t *testing.T) {
6464
var result {{$.Name}}
6565
err := faker.FakeData(&sample)
6666
if err != nil {
67-
t.Errorf(err.Error())
67+
t.Error(err.Error())
6868
}
6969
err = faker.FakeData(&result)
7070
if err != nil {
71-
t.Errorf(err.Error())
71+
t.Error(err.Error())
7272
}
7373
{{- range $.Fields}}
7474
{{- if (eq .Type "bool") }}
@@ -123,11 +123,11 @@ func Test{{$.Name}}{{.}}False(t *testing.T) {
123123
json := jsoniter.ConfigCompatibleWithStandardLibrary
124124
a, err := json.Marshal(&sample.a)
125125
if err != nil {
126-
t.Errorf(err.Error())
126+
t.Error(err.Error())
127127
}
128128
b, err := json.Marshal(&sample.b)
129129
if err != nil {
130-
t.Errorf(err.Error())
130+
t.Error(err.Error())
131131
}
132132
{{- if eq . "Equal" }}
133133
t.Errorf("Expected {{$.Name}} to be different, but it is not %s %s", a, b)

config-parser/generate/config-file.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -356,7 +356,7 @@ var testFooter = ` }
356356
buffer.WriteString(config.Config)
357357
p, err := parser.New(options.Reader(&buffer))
358358
if err != nil {
359-
t.Fatalf(err.Error())
359+
t.Fatalf("%v", err.Error())
360360
}
361361
result := p.String()
362362
if result != config.Config {
@@ -366,7 +366,7 @@ var testFooter = ` }
366366
t.Error("======== RESULT ===========")
367367
t.Error(result)
368368
t.Error("===========================")
369-
t.Fatalf("configurations does not match")
369+
t.Fatalf("%v", "configurations does not match")
370370
}
371371
})
372372
}

config-parser/generate/test.tmpl

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -58,12 +58,12 @@ func Test{{ $StructName }}{{ .Dir }}(t *testing.T) {
5858
}
5959
if shouldPass {
6060
if err != nil {
61-
t.Errorf(err.Error())
61+
t.Error(err.Error())
6262
return
6363
}
6464
result, err := parser.Result()
6565
if err != nil {
66-
t.Errorf(err.Error())
66+
t.Error(err.Error())
6767
return
6868
}
6969
var returnLine string
@@ -73,15 +73,15 @@ func Test{{ $StructName }}{{ .Dir }}(t *testing.T) {
7373
returnLine = fmt.Sprintf("%s # %s", result[0].Data, result[0].Comment)
7474
}
7575
if command != returnLine {
76-
t.Errorf(fmt.Sprintf("error: has [%s] expects [%s]", returnLine, command))
76+
t.Errorf("error: has [%s] expects [%s]", returnLine, command)
7777
}
7878
} else {
7979
if err == nil {
80-
t.Errorf(fmt.Sprintf("error: did not throw error for line [%s]", line))
80+
t.Errorf("error: did not throw error for line [%s]", line)
8181
}
8282
_, parseErr := parser.Result()
8383
if parseErr == nil {
84-
t.Errorf(fmt.Sprintf("error: did not throw error on result for line [%s]", line))
84+
t.Errorf("error: did not throw error on result for line [%s]", line)
8585
}
8686
}
8787
})
@@ -104,12 +104,12 @@ func Test{{ $StructName }}{{ .Dir }}(t *testing.T) {
104104
err = ProcessLine(line, parser)
105105
}
106106
if err != nil {
107-
t.Errorf(err.Error())
107+
t.Error(err.Error())
108108
return
109109
}
110110
result, err := parser.Result()
111111
if err != nil {
112-
t.Errorf(err.Error())
112+
t.Error(err.Error())
113113
return
114114
}
115115
var returnLine string
@@ -119,7 +119,7 @@ func Test{{ $StructName }}{{ .Dir }}(t *testing.T) {
119119
returnLine = fmt.Sprintf("%s # %s", result[0].Data, result[0].Comment)
120120
}
121121
if expected != returnLine {
122-
t.Errorf(fmt.Sprintf("error: has [%s] expects [%s]", returnLine, expected))
122+
t.Errorf("error: has [%s] expects [%s]", returnLine, expected)
123123
}
124124
})
125125
}
@@ -156,12 +156,12 @@ func TestAlias{{ $StructName }}{{ .Dir }}(t *testing.T) {
156156
}
157157
if shouldPass {
158158
if err != nil {
159-
t.Errorf(err.Error())
159+
t.Error(err.Error())
160160
return
161161
}
162162
result, err := parser.Result()
163163
if err != nil {
164-
t.Errorf(err.Error())
164+
t.Error(err.Error())
165165
return
166166
}
167167
var returnLine string
@@ -171,15 +171,15 @@ func TestAlias{{ $StructName }}{{ .Dir }}(t *testing.T) {
171171
returnLine = fmt.Sprintf("%s # %s", result[0].Data, result[0].Comment)
172172
}
173173
if command != returnLine {
174-
t.Errorf(fmt.Sprintf("error: has [%s] expects [%s]", returnLine, command))
174+
t.Errorf("error: has [%s] expects [%s]", returnLine, command)
175175
}
176176
} else {
177177
if err == nil {
178-
t.Errorf(fmt.Sprintf("error: did not throw error for line [%s]", line))
178+
t.Errorf("error: did not throw error for line [%s]", line)
179179
}
180180
_, parseErr := parser.Result()
181181
if parseErr == nil {
182-
t.Errorf(fmt.Sprintf("error: did not throw error on result for line [%s]", line))
182+
t.Errorf("error: did not throw error on result for line [%s]", line)
183183
}
184184
}
185185
})

config-parser/spoe/tests/configs/spoe_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ func TestWholeConfigs(t *testing.T) {
2626
result := p.String()
2727
if result != config.Config {
2828
compare(t, config.Config, result)
29-
t.Fatalf("configurations does not match")
29+
t.Fatalf("%v", "configurations does not match")
3030
}
3131
})
3232
}

config-parser/spoe/tests/event_generated_test.go

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

config-parser/spoe/tests/spoe-section_generated_test.go

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

config-parser/tests/acl_generated_test.go

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

config-parser/tests/array-string-kv_generated_test.go

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

config-parser/tests/balance_generated_test.go

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

config-parser/tests/bind-process_generated_test.go

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)