Skip to content

Commit ef96193

Browse files
committed
add dns-accept-family option ing global section
Signed-off-by: Vincent Gramer <vgramer@haproxy.com>
1 parent 6fa1f97 commit ef96193

10 files changed

Lines changed: 53 additions & 2 deletions

File tree

config-parser/section-parsers.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -460,6 +460,7 @@ func (p *configParser) getGlobalParser() *Parsers { //nolint: maintidx
460460
addParser(parser, &sequence, &simple.Enabled{Name: "expose-deprecated-directives"})
461461
addParser(parser, &sequence, &simple.Time{Name: "force-cfg-parser-pause"})
462462
addParser(parser, &sequence, &simple.Time{Name: "warn-blocked-traffic-after"})
463+
addParser(parser, &sequence, &simple.Word{Name: "dns-accept-family"})
463464
// the ConfigSnippet must be at the end to parsers load order to ensure
464465
// the overloading of any option has been declared previously
465466
addParser(parser, &sequence, &parsers.ConfigSnippet{})

config-parser/tests/configs/haproxy.cfg.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@ global
6666
expose-deprecated-directives
6767
force-cfg-parser-pause 1s
6868
warn-blocked-traffic-after 50ms
69+
dns-accept-family ipv4,ipv6
6970
# random comment before snippet
7071
###_config-snippet_### BEGIN
7172
tune.ssl.default-dh-param 2048

configuration/global.go

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2170,6 +2170,12 @@ func ParseGlobalSection(p parser.Parser) (*models.Global, error) { //nolint:goco
21702170
}
21712171
global.DeviceAtlasOptions = deviceAtlasOptions
21722172

2173+
dnsAcceptFamily, err := parseStringOption(p, "dns-accept-family")
2174+
if err != nil {
2175+
return nil, err
2176+
}
2177+
global.DNSAcceptFamily = dnsAcceptFamily
2178+
21732179
envOptions, err := parseEnvironmentOptions(p)
21742180
if err != nil {
21752181
return nil, err
@@ -3053,6 +3059,10 @@ func SerializeGlobalSection(p parser.Parser, data *models.Global, opt *options.C
30533059
return err
30543060
}
30553061

3062+
if err := serializeStringOption(p, "dns-accept-family", data.DNSAcceptFamily); err != nil {
3063+
return err
3064+
}
3065+
30563066
if err := serializeStringOption(p, "description", data.Description); err != nil {
30573067
return err
30583068
}

models/global_base.go

Lines changed: 21 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

models/global_base_compare.go

Lines changed: 8 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

models/global_base_compare_test.go

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

specification/build/haproxy_spec.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2147,6 +2147,10 @@ definitions:
21472147
x-display-name: Text that describes the instance
21482148
device_atlas_options:
21492149
$ref: '#/definitions/device_atlas_options'
2150+
dns_accept_family:
2151+
pattern: ^[^\s]+$
2152+
type: string
2153+
x-display-name: DNS accept family
21502154
environment_options:
21512155
$ref: '#/definitions/environment_options'
21522156
expose_deprecated_directives:

specification/models/configuration/global.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -311,6 +311,10 @@ global_base:
311311
quic:
312312
type: string
313313
enum: ["enabled", "disabled"]
314+
dns_accept_family:
315+
pattern: ^[^\s]+$
316+
type: string
317+
x-display-name: DNS accept family
314318
environment_options:
315319
$ref: "#/definitions/environment_options"
316320
performance_options:

test/configuration_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -276,6 +276,7 @@ global
276276
ocsp-update.maxdelay 10
277277
ocsp-update.mindelay 7
278278
ocsp-update.mode on
279+
dns-accept-family ipv4,ipv6
279280
warn-blocked-traffic-after 50ms
280281
281282
defaults test_defaults # testing_defaults

test/expected/structured.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,7 @@
157157
"properties_cookie": "chocolate",
158158
"separator": "-"
159159
},
160+
"dns_accept_family": "ipv4,ipv6",
160161
"expose_deprecated_directives": true,
161162
"expose_experimental_directives": true,
162163
"external_check": true,

0 commit comments

Comments
 (0)