REORG/MEDIUM: service: port is optional via nil value#121
Closed
prometherion wants to merge 1 commit intohaproxytech:masterfrom
Closed
REORG/MEDIUM: service: port is optional via nil value#121prometherion wants to merge 1 commit intohaproxytech:masterfrom
prometherion wants to merge 1 commit intohaproxytech:masterfrom
Conversation
dolmen
reviewed
May 15, 2025
| type ServiceServer struct { | ||
| Address string | ||
| Port int | ||
| Port *int64 |
Contributor
There was a problem hiding this comment.
Why Int64 ? TCP ports are just 16 bits.
Member
Author
There was a problem hiding this comment.
Simplifying types equality and assignment with other struct types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port can be optional via pointer (/cc haproxytech/dataplaneapi#369)