Commit e917e8d
committed
MINOR: move r.Valid assignment after backendRef loop in HTTPRouteRule and TLSRouteRule
r.Valid = routeValid was inside the loop in the success branch only; failure
paths hit continue and skipped it, leaving r.Valid at its zero value (false).
The result was correct by coincidence but fragile. Moving the assignment after
the loop makes the intent explicit and safe against future refactors.1 parent 0d61669 commit e917e8d
2 files changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
82 | 82 | | |
83 | 83 | | |
84 | 84 | | |
85 | | - | |
86 | 85 | | |
| 86 | + | |
87 | 87 | | |
88 | 88 | | |
89 | 89 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
78 | 78 | | |
79 | 79 | | |
80 | 80 | | |
81 | | - | |
82 | 81 | | |
| 82 | + | |
83 | 83 | | |
84 | 84 | | |
85 | 85 | | |
| |||
0 commit comments