BUG/MEDIUM: fix periodic reload due to wrong log target changes in Global CR

hdurand0710 · oktalz · commit b34f5bc3ab5b · 2026-04-27T20:29:57.000Z
We were comparing the previous Global without the log target children with a new Global with the log target children, which always resulted in a diff and a reload if the new one had log targets.
diff --git a/pkg/controller/global.go b/pkg/controller/global.go
@@ -58,6 +58,7 @@ func (c *HAProxyController) globalCfg() {
 		logger.Error(errL)
 		return
 	}
+	global.LogTargetList = lg
 	newGlobal, err = annotations.ModelGlobal("cr-global", c.podNamespace, c.store, c.store.ConfigMaps.Main.Annotations)
 	if err != nil {
 		logger.Errorf("Global config: %s", err)
@@ -80,6 +81,7 @@ func (c *HAProxyController) globalCfg() {
 	if newGlobal.TuneSslOptions == nil {
 		newGlobal.TuneSslOptions = &models.TuneSslOptions{}
 	}
+	newGlobal.LogTargetList = newLg
 
 	env.SetGlobal(newGlobal, &newLg, c.haproxy.Env)
 	diff := newGlobal.Diff(*global)

Original file line number	Diff line number	Diff line change
`@@ -58,6 +58,7 @@ func (c *HAProxyController) globalCfg() {`
`58`	`58`	`logger.Error(errL)`
`59`	`59`	`return`
`60`	`60`	`}`
	`61`	`+ global.LogTargetList = lg`
`61`	`62`	`newGlobal, err = annotations.ModelGlobal("cr-global", c.podNamespace, c.store, c.store.ConfigMaps.Main.Annotations)`
`62`	`63`	`if err != nil {`
`63`	`64`	`logger.Errorf("Global config: %s", err)`
`@@ -80,6 +81,7 @@ func (c *HAProxyController) globalCfg() {`
`80`	`81`	`if newGlobal.TuneSslOptions == nil {`
`81`	`82`	`newGlobal.TuneSslOptions = &models.TuneSslOptions{}`
`82`	`83`	`}`
	`84`	`+ newGlobal.LogTargetList = newLg`
`83`	`85`
`84`	`86`	`env.SetGlobal(newGlobal, &newLg, c.haproxy.Env)`
`85`	`87`	`diff := newGlobal.Diff(*global)`