BUILD/MINOR: move c.SyncData() out to main as go routine and run c.Start() before k.MonitorChanges()

Author: cxfcxf

deploy/tests/tnr/routeacl/suite_test.go

@@ -126,7 +126,8 @@ func (suite *UseBackendSuite) UseBackendFixture() (eventChan chan k8ssync.SyncDa
 		WithUpdateStatusManager(&updateStatusManager{}).
 		WithArgs(osArgs).Build()
 
-	go controller.Start()
+	controller.Start()
+	go controller.SyncData()
 
 	// Now sending store events for test setup
 	ns := store.Namespace{Name: "ns", Status: store.ADDED}
@@ -239,7 +240,8 @@ func (suite *UseBackendSuite) NonWildcardHostFixture() (eventChan chan k8ssync.S
 		WithUpdateStatusManager(&updateStatusManager{}).
 		WithArgs(osArgs).Build()
 
-	go controller.Start()
+	controller.Start()
+	go controller.SyncData()
 
 	// Now sending store events for test setup
 	ns := store.Namespace{Name: "ns", Status: store.ADDED}
@@ -345,7 +347,8 @@ func (suite *UseBackendSuite) WildcardHostFixture() (eventChan chan k8ssync.Sync
 		WithUpdateStatusManager(&updateStatusManager{}).
 		WithArgs(osArgs).Build()
 
-	go controller.Start()
+	controller.Start()
+	go controller.SyncData()
 
 	// Now sending store events for test setup
 	ns := store.Namespace{Name: "ns", Status: store.ADDED}

deploy/tests/ut/acls/suite_test.go

@@ -108,7 +108,8 @@ func (suite *ACLSuite) UseACLFixture() (eventChan chan k8ssync.SyncDataEvent) {
 		WithUpdateStatusManager(&FakeUpdateSatusManager{}).
 		WithArgs(osArgs).Build()
 
-	go controller.Start()
+	controller.Start()
+	go controller.SyncData()
 
 	backend := v3.Backend{
 		ObjectMeta: metav1.ObjectMeta{

deploy/tests/ut/httprequests/suite_test.go

@@ -108,7 +108,8 @@ func (suite *HTTPRequestsSuite) UseHTTPRequestsFixture() (eventChan chan k8ssync
 		WithUpdateStatusManager(&FakeUpdateSatusManager{}).
 		WithArgs(osArgs).Build()
 
-	go controller.Start()
+	controller.Start()
+	go controller.SyncData()
 
 	backend := v3.Backend{
 		ObjectMeta: metav1.ObjectMeta{

main.go

@@ -177,8 +177,9 @@ func main() {
 
 	c.SetGatewayAPIInstalled(isGatewayAPIInstalled)
 
+	c.Start()
 	go k.MonitorChanges(eventChan, stop, osArgs, isGatewayAPIInstalled)
-	go c.Start()
+	go c.SyncData()
 	// Catch QUIT signals
 	signalC := make(chan os.Signal, 1)
 	signal.Notify(signalC, os.Interrupt, syscall.SIGTERM, syscall.SIGUSR1)

pkg/controller/controller.go

@@ -103,8 +103,6 @@ func (c *HAProxyController) Start() {
 	c.initHandlers()
 	logger.Error(c.setupHAProxyRules())
 	logger.Error(os.Chdir(c.haproxy.Env.CfgDir))
-
-	c.SyncData()
 }
 
 // Stop handles shutting down HAProxyController