MINOR: Revise SSL Redirection on default HTTPS port#788
Open
BuJo wants to merge 3 commits intohaproxytech:masterfrom
Open
MINOR: Revise SSL Redirection on default HTTPS port#788BuJo wants to merge 3 commits intohaproxytech:masterfrom
BuJo wants to merge 3 commits intohaproxytech:masterfrom
Conversation
Contributor
|
Does this still require to set the |
Author
Yes, the default of 8443 is untouched. |
BuJo
force-pushed
the
ssl-redirect-default-port
branch
from
0bf4ab3 to
909369b
Compare
Author
|
Force pushed due to spelling mistakes in the commit messages (unsure on how to test locally). |
BuJo
force-pushed
the
ssl-redirect-default-port
branch
2 times, most recently
from
443cf92 to
5c84c64
Compare
* Split host and SSL redirects conceptually, as they do distinct things. The SSL redirect does not look at the host setting when redirecting.
* The default for the controller is to generate redirects to port 8443, as this port can be bound to in a rootless container. * Running the container in a Kubernetes setting having a service port mapping to port 443 introduces the need to change this default configuration. * Having the default HTTPS port 443 appended to the redirect breaks certain caching behaviors and is thus not ideal. * This commit aims to purely switch the scheme from HTTP to HTTPS without changing anything else about the request, the only user visible change being that the :443 in the redirect URL is no longer visible. * fixes haproxytech#642
BuJo
force-pushed
the
ssl-redirect-default-port
branch
from
5c84c64 to
24cc55d
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
8443, as this port can be bound to in a rootless container.443appended to the redirect breaks certain caching behaviours and is thus not ideal.:443in the redirect URL is no longer visible.