BUILD/MINOR: Switch order on inside c.Start(), so restart will work and run Start() synchronously and split SyncData() into its own goroutine#793
Open
cxfcxf wants to merge 2 commits into
Conversation
a7dedaf to
882280a
Compare
882280a to
63a4b84
Compare
4901e11 to
f7e2a68
Compare
…art() before k.MonitorChanges()
f7e2a68 to
29430c5
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When running the controller in external mode (e.g. under systemd), systemctl restart hangs ~50% of the time. The controller gets stuck and never processes Kubernetes events.
Root Cause
On restart, the old HAProxy may still be alive briefly. Start() previously ran APICommitTransaction calls before Service("start"), which stripped the daemon directive from the on-disk config. When the old HAProxy finally exited and a new one launched, it ran in the foreground, blocking forever.
Fix