Skip to content

BUG/MAJOR: service: deep-copy cr-backend spec to fix cross-service server contamination #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cxfcxf wants to merge 1 commit into
base: master
Choose a base branch
from
Open

BUG/MAJOR: service: deep-copy cr-backend spec to fix cross-service server contamination #802

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions pkg/service/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,16 @@ func (s *Service) getBackendModel(store store.K8s, a annotations.Annotations, cl
// get/create backend Model
backend, err = annotations.ModelBackend("cr-backend", s.resource.Namespace, store, s.annotations...)
logger.Warning(err)
if backend != nil {
// Deep-copy the CR object before mutating it: multiple services may share the
// same cr-backend annotation and therefore the same *v3.BackendSpec pointer in
// the store. Without a copy, mutations below (BackendBase.Name, Servers map,
// etc.) bleed across services, causing one backend's server list to contaminate
// another's.
var backendCopy v3.BackendSpec
backend.DeepCopyInto(&backendCopy)
backend = &backendCopy
}
if backend == nil {
backend = &v3.BackendSpec{
Backend: models.Backend{
Expand Down
Loading