BUG/MINOR: rules: apply SSL redirect before basic auth#821
Open
dragoangel wants to merge 1 commit into
Open
Conversation
…ntend Prevents basic-auth challenge on plain HTTP before TLS redirect, resolves haproxytech#807 Signed-off-by: Dmytro Alieksieiev <1865999+dragoangel@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes ordering of HTTP request rules so redirect executes before auth for ingress flows using SSL redirect.
Problem
Current ordering can challenge basic auth on HTTP first, then redirect, which is insecure and causes wrong behavior for issue #807 scenario.
What changed
types.gotypes_test.goorder_refresh_test.govalidating final order is:redirect, thenauthValidation
go test ./pkg/haproxy/rulesVerified runtime test output order during debugging: redirect first, auth second.
Impact
Behavior change is ordering of redirect vs auth vs other directives.
Other options considered
A possible alternative to rule reordering is to avoid rendering basic auth on the HTTP (non-TLS) frontend when SSL redirect is enabled for the ingress. In that model, the HTTP frontend would only perform redirect and would not pass traffic directly, so basic auth on HTTP would not be needed. If an ingress has basic auth but does not enable TLS redirect, then basic auth would still be rendered on HTTP for that ingress.
Trade-offs
The current PR approach (redirect before auth) also makes redirect happen before other HTTP request rules such as rate limits. This may be desirable for security/UX, but it can also change expected behavior for users who rely on rate limiting before redirect. For transparency, this alternative is highlighted as a valid implementation path and, if maintainers prefer it, I can implement it either in this PR or in a dedicated follow-up PR.
Expected result
Users are redirected to HTTPS before basic-auth challenge.