BUG/MEDIUM: controller: stop duplicating default local backend config snippet - #833
Open
hedgieinsocks wants to merge 1 commit into
Open
BUG/MEDIUM: controller: stop duplicating default local backend config snippet#833hedgieinsocks wants to merge 1 commit into
hedgieinsocks wants to merge 1 commit into
Conversation
… snippet Overwriting defaultLocalService.Annotations with ConfigMap annotations made the global backend-config-snippet get applied twice to the default local backend, breaking HAProxy reload. Commit 3ff14e4 previously fixed this, but the bug was reintroduced in fb58ed3. Fixes haproxytech#829.
Author
|
@ivanmatmati Hello, since you authored the related commits in the past, could you please take a look at this PR to ensure this change does not introduce another issue that might not be obvious to people not familiar with the codebase? |
ivanmatmati
self-requested a review
July 27, 2026 15:03
Collaborator
|
Hi @hedgieinsocks , sure thing, I'm going to check that. |
Collaborator
|
I can confirm this is a regression, we'll consider your MR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overwriting defaultLocalService.Annotations with ConfigMap annotations made the global backend-config-snippet get applied twice to the default local backend, breaking HAProxy reload.
Commit 3ff14e4 previously fixed this, but the bug was reintroduced in fb58ed3.
Fixes #829.