BUG/MINOR: http-ana: Remove a debugging memset on redirect

capflam · capflam · commit 7bfa568e2717 · 2026-06-15T08:55:56.000+02:00
A memset used for debug was left when "keep-query" option was added. Let's
remove it. This bug should be harmless but it consumes extra CPU for
nothing.

This patch should be backported as far as 3.2.
diff --git a/src/http_ana.c b/src/http_ana.c
@@ -2517,7 +2517,6 @@ int http_apply_redirect_rule(struct redirect_rule *rule, struct stream *s, struc
 		}
 		case REDIRECT_TYPE_LOCATION:
 		default:
-			memset(chunk->area, 0x50, chunk->size);
 			if (rule->rdr_str) { /* this is an old "redirect" rule */
 				/* add location */
 				if (!chunk_memcat(chunk, rule->rdr_str, rule->rdr_len))

Original file line number	Diff line number	Diff line change
`@@ -2517,7 +2517,6 @@ int http_apply_redirect_rule(struct redirect_rule rule, struct stream s, struc`
`2517`	`2517`	`}`
`2518`	`2518`	`case REDIRECT_TYPE_LOCATION:`
`2519`	`2519`	`default:`
`2520`		`- memset(chunk->area, 0x50, chunk->size);`
`2521`	`2520`	`if (rule->rdr_str) { /* this is an old "redirect" rule */`
`2522`	`2521`	`/* add location */`
`2523`	`2522`	`if (!chunk_memcat(chunk, rule->rdr_str, rule->rdr_len))`