Updated test for cross-platform compatibility and (hopefully) fixed formatting for good now

Author: Gedlex

can/io/asc.py

@@ -116,7 +116,7 @@ def _extract_header(self) -> None:
 
     @staticmethod
     def _datetime_to_timestamp(datetime_string: str) -> float:
-        MONTH_MAP = {
+        month_map = {
             "jan": 1,
             "feb": 2,
             "mar": 3,
@@ -135,7 +135,7 @@ def _datetime_to_timestamp(datetime_string: str) -> float:
             "dez": 12,
         }
 
-        DATETIME_FORMATS = (
+        datetime_formats = (
             "%m %d %I:%M:%S.%f %p %Y",
             "%m %d %I:%M:%S %p %Y",
             "%m %d %H:%M:%S.%f %Y",
@@ -148,12 +148,12 @@ def _datetime_to_timestamp(datetime_string: str) -> float:
         month = datetime_string_parts[0].strip().lower()
 
         try:
-            datetime_string_parts[0] = f"{MONTH_MAP[month]:02d}"
+            datetime_string_parts[0] = f"{month_map[month]:02d}"
         except KeyError:
             raise ValueError(f"Unsupported month abbreviation: {month}") from None
         datetime_string = " ".join(datetime_string_parts)
 
-        for format_str in DATETIME_FORMATS:
+        for format_str in datetime_formats:
             try:
                 return datetime.strptime(datetime_string, format_str).timestamp()
             except ValueError:

test/logformats_test.py

@@ -682,12 +682,30 @@ def test_write(self):
 
     @parameterized.expand(
         [
-            ("May 27 04:09:35.000 pm 2014", 1401199775.0),
-            ("Mai 27 04:09:35.000 pm 2014", 1401199775.0),
-            ("Apr 28 10:44:52.480 2022", 1651135492.48),
-            ("Sep 30 15:06:13.191 2017", 1506776773.191),
-            ("Sep 30 15:06:13.191 pm 2017", 1506776773.191),
-            ("Sep 30 15:06:13.191 am 2017", 1506776773.191),
+            (
+                "May 27 04:09:35.000 pm 2014",
+                datetime(2014, 5, 27, 16, 9, 35, 0).timestamp(),
+            ),
+            (
+                "Mai 27 04:09:35.000 pm 2014",
+                datetime(2014, 5, 27, 16, 9, 35, 0).timestamp(),
+            ),
+            (
+                "Apr 28 10:44:52.480 2022",
+                datetime(2022, 4, 28, 10, 44, 52, 480).timestamp(),
+            ),
+            (
+                "Sep 30 15:06:13.191 2017",
+                datetime(2017, 9, 30, 15, 6, 13, 191).timestamp(),
+            ),
+            (
+                "Sep 30 15:06:13.191 pm 2017",
+                datetime(2017, 9, 30, 15, 6, 13, 191).timestamp(),
+            ),
+            (
+                "Sep 30 15:06:13.191 am 2017",
+                datetime(2017, 9, 30, 15, 6, 13, 191).timestamp(),
+            ),
         ]
     )
     def test_datetime_to_timestamp(