Skip to content

Commit e24b5a1

Browse files
authored
CI: fix security workflow + bump actions for Node.js 24 (#33)
* CI: fix security workflow + bump actions for Node.js 24 - security.yml: drop invalid `issues-reason:` and `checks-reason:` permission keys (those aren't real GitHub Actions permissions; their presence broke the workflow at parse time on every push). Intent preserved as YAML comments above the `permissions:` block. - Bump actions off the deprecated Node.js 20 runner: - actions/checkout v4 → v5 - actions/setup-python v4/v5 → v6 - actions/upload-artifact v4 → v5 - actions/download-artifact v4 → v5 - astral-sh/setup-uv v3/v4 → v8 - rustsec/audit-check v1.4.1 → v2 PyO3/maturin-action and github/codeql-action stay on their rolling major tags (v1 and v3 respectively). * Pin to existing major tags: setup-uv@v7, audit-check@v2.0.0 astral-sh/setup-uv only publishes specific tags past v7 (no v8 alias). rustsec/audit-check has no moving major tag — pin to v2.0.0.
1 parent 4f8f848 commit e24b5a1

3 files changed

Lines changed: 26 additions & 26 deletions

File tree

.github/workflows/ci.yml

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,10 @@ jobs:
2626
matrix:
2727
python-version: ["3.11", "3.12"]
2828
steps:
29-
- uses: actions/checkout@v4
29+
- uses: actions/checkout@v5
3030

3131
- name: Install uv
32-
uses: astral-sh/setup-uv@v4
32+
uses: astral-sh/setup-uv@v7
3333
with:
3434
version: "latest"
3535

@@ -56,10 +56,10 @@ jobs:
5656
name: Code Quality & Type Checking
5757
runs-on: ubuntu-latest
5858
steps:
59-
- uses: actions/checkout@v4
59+
- uses: actions/checkout@v5
6060

6161
- name: Install uv
62-
uses: astral-sh/setup-uv@v4
62+
uses: astral-sh/setup-uv@v7
6363
with:
6464
version: "latest"
6565

@@ -119,8 +119,8 @@ jobs:
119119
- runner: ubuntu-latest
120120
target: ppc64le
121121
steps:
122-
- uses: actions/checkout@v4
123-
- uses: actions/setup-python@v5
122+
- uses: actions/checkout@v5
123+
- uses: actions/setup-python@v6
124124
with:
125125
python-version: '3.11'
126126
- name: Build wheels
@@ -131,7 +131,7 @@ jobs:
131131
sccache: 'true'
132132
manylinux: auto
133133
- name: Upload wheels
134-
uses: actions/upload-artifact@v4
134+
uses: actions/upload-artifact@v5
135135
with:
136136
name: wheels-linux-${{ matrix.platform.target }}
137137
path: dist
@@ -147,8 +147,8 @@ jobs:
147147
- runner: windows-latest
148148
target: x86
149149
steps:
150-
- uses: actions/checkout@v4
151-
- uses: actions/setup-python@v5
150+
- uses: actions/checkout@v5
151+
- uses: actions/setup-python@v6
152152
with:
153153
python-version: '3.11'
154154
architecture: ${{ matrix.platform.target }}
@@ -159,7 +159,7 @@ jobs:
159159
args: --release --out dist --find-interpreter
160160
sccache: 'true'
161161
- name: Upload wheels
162-
uses: actions/upload-artifact@v4
162+
uses: actions/upload-artifact@v5
163163
with:
164164
name: wheels-windows-${{ matrix.platform.target }}
165165
path: dist
@@ -175,8 +175,8 @@ jobs:
175175
- runner: macos-14
176176
target: aarch64
177177
steps:
178-
- uses: actions/checkout@v4
179-
- uses: actions/setup-python@v5
178+
- uses: actions/checkout@v5
179+
- uses: actions/setup-python@v6
180180
with:
181181
python-version: '3.11'
182182
- name: Build wheels
@@ -186,7 +186,7 @@ jobs:
186186
args: --release --out dist --find-interpreter
187187
sccache: 'true'
188188
- name: Upload wheels
189-
uses: actions/upload-artifact@v4
189+
uses: actions/upload-artifact@v5
190190
with:
191191
name: wheels-macos-${{ matrix.platform.target }}
192192
path: dist
@@ -195,14 +195,14 @@ jobs:
195195
runs-on: ubuntu-latest
196196
needs: [test, lint]
197197
steps:
198-
- uses: actions/checkout@v4
198+
- uses: actions/checkout@v5
199199
- name: Build sdist
200200
uses: PyO3/maturin-action@v1
201201
with:
202202
command: sdist
203203
args: --out dist
204204
- name: Upload sdist
205-
uses: actions/upload-artifact@v4
205+
uses: actions/upload-artifact@v5
206206
with:
207207
name: wheels-sdist
208208
path: dist
@@ -215,7 +215,7 @@ jobs:
215215
permissions:
216216
id-token: write
217217
steps:
218-
- uses: actions/download-artifact@v4
218+
- uses: actions/download-artifact@v5
219219
- name: Publish to PyPI
220220
uses: PyO3/maturin-action@v1
221221
env:

.github/workflows/claude.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525
id-token: write
2626
steps:
2727
- name: Checkout repository
28-
uses: actions/checkout@v4
28+
uses: actions/checkout@v5
2929
with:
3030
fetch-depth: 1
3131

.github/workflows/security.yml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -17,21 +17,21 @@ jobs:
1717
security:
1818
name: Security Scan
1919
runs-on: ubuntu-latest
20+
# issues: write — rustsec/audit-check creates issues for new advisories.
21+
# checks: write — rustsec/audit-check posts check annotations.
2022
permissions:
2123
issues: write
22-
issues-reason: to create issues
2324
checks: write
24-
checks-reason: to create check
2525
steps:
26-
- uses: actions/checkout@v4
27-
26+
- uses: actions/checkout@v5
27+
2828
- name: Run Rust security audit
29-
uses: rustsec/audit-check@v1.4.1
29+
uses: rustsec/audit-check@v2.0.0
3030
with:
3131
token: ${{ secrets.GITHUB_TOKEN }}
32-
32+
3333
- name: Install uv
34-
uses: astral-sh/setup-uv@v4
34+
uses: astral-sh/setup-uv@v7
3535
with:
3636
version: "latest"
3737

@@ -56,8 +56,8 @@ jobs:
5656
security-events: write
5757
steps:
5858
- name: Checkout repository
59-
uses: actions/checkout@v4
60-
59+
uses: actions/checkout@v5
60+
6161
- name: Initialize CodeQL
6262
uses: github/codeql-action/init@v3
6363
with:

0 commit comments

Comments
 (0)