Any requests for API-breaking changes #181
-
|
I’m planning to make a first v2.x release soon with all the API-breaking changes, so if anyone has any other requests for more API-breaking changes, now is a good time to request them. We are unlikely to get any such breaking changes again in a long time. |
Beta Was this translation helpful? Give feedback.
Replies: 7 comments 24 replies
-
|
@akash-joshi @chearon @ghostdevv @graphicore @justvanrossum @lianghai @simoncozens @tomasdev |
Beta Was this translation helpful? Give feedback.
-
|
Nothing off the top of my head, but I’ll think about this. At this point, mostly I’m interested in closely reviewing the eventual distribution (see also the current one https://www.npmjs.com/package/harfbuzzjs?activeTab=code), in order to make sure a minimal, well understood set of files and API surface are exposed. Will you be creating pre-releases in https://github.com/harfbuzz/harfbuzzjs/releases for review? Btw, for such a small project, using both “Issues” and “Discussions” is kinda confusing… Big projects benefit from this because they need to have multiple levels of triaging, typically from “Discussions” to “Issues” to “Pull requests”. |
Beta Was this translation helpful? Give feedback.
-
|
Since this is a breaking release, it would be really valuable to have a changelog or migration guide (e.g. MIGRATING.md) documenting all the changes from 1.x to 2.x. Even a simple list of what changed and why would go a long way. The bigger question is - where do we release this 😅? With the V2 release? |
Beta Was this translation helpful? Give feedback.
-
|
Can (did?) we get rid of the explicit I assume the recent changes make it possible for webpack to pick up the .wasm file automatically? |
Beta Was this translation helpful? Give feedback.
-
|
Do people feel it’s worth the trouble to switch the casing of Line 335 in abcd821 Line 50 in abcd821 I almost started working on a PR, but then realized there’s also a lot of |
Beta Was this translation helpful? Give feedback.
-
|
There seems to be some confusion about the usage of
For example, this overloading doesn’t seem necessary: Lines 73 to 76 in abcd821 And here
Lines 376 to 382 in abcd821
Indeed, how to use |
Beta Was this translation helpful? Give feedback.
-
|
If there are no objections, I’m going to make a final v1.0.0 in the next few days. |
Beta Was this translation helpful? Give feedback.




https://github.com/harfbuzz/harfbuzzjs/releases/tag/v1.0.0
Thanks everyone for your input.