Skip to content

Commit 86836dc

Browse files
committed
fix(hm-exec): skip ExecutorInput in tracing span so secret env values aren't logged
1 parent c339fcf commit 86836dc

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

  • crates/hm-exec/src/local/runner

crates/hm-exec/src/local/runner/vm.rs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,9 @@ impl StepRunner for VmRunner {
6666
}
6767
}
6868

69-
#[tracing::instrument(skip(vm, ctx), fields(step_key = %input.step.key))]
69+
// `input` is skipped: its `env` map holds resolved secret values, which must
70+
// never be Debug-recorded into a span field. Only the safe `step_key` is logged.
71+
#[tracing::instrument(skip(vm, ctx, input), fields(step_key = %input.step.key))]
7072
async fn run_step_vm(vm: &HmVm, ctx: &StepContext, input: ExecutorInput) -> Result<StepResult> {
7173
let policy = match &input.cache_lookup {
7274
CacheDecision::Hit { tag } | CacheDecision::MissBuildAs { tag } => {

0 commit comments

Comments
 (0)