refactor(hm-plugin-cloud): render_prefs returns a (bool, bool) tuple whose two fields are trivially swappable (#118)

Author: markovejnovic

crates/hm-plugin-cloud/src/settings.rs

@@ -70,18 +70,36 @@ pub fn anon_client() -> Result<(HarmontClient, String)> {
 
 /// Render preferences for cloud commands that stream through `hm-render`.
 ///
-/// Returns `(color, logs)`, both derived from `hm-render`'s shared TTY/color
-/// helpers (the single source of truth, also used by `hm/src/context.rs`):
-/// - `color` — ANSI enabled when `NO_COLOR` is unset and stderr is a TTY.
-///   The plugin verbs have no `--no-color` flag, so we pass `false` for the
-///   flag; the `--no-color` asymmetry vs. the host `hm run` path is explicit
-///   here at the call site.
-/// - `logs` — force the streaming `HumanRenderer` over the live
-///   `ProgressRenderer`. True when stdout is **not** an interactive terminal
-///   (CI / pipe / log file), so nothing animates into a non-TTY sink.
-#[must_use]
-pub fn render_prefs() -> (bool, bool) {
-    (hm_render::color_enabled(false), hm_render::stdout_piped())
+/// Both fields are derived from `hm-render`'s shared TTY/color helpers (the
+/// single source of truth, also used by `hm/src/context.rs`).
+#[derive(Debug, Clone, Copy)]
+pub struct RenderPrefs {
+    /// ANSI enabled when `NO_COLOR` is unset and stderr is a TTY.
+    ///
+    /// The plugin verbs have no `--no-color` flag, so we pass `false` for the
+    /// flag; the `--no-color` asymmetry vs. the host `hm run` path is explicit
+    /// here at the call site.
+    pub color: bool,
+    /// Force the streaming `HumanRenderer` over the live `ProgressRenderer`.
+    ///
+    /// True when stdout is **not** an interactive terminal (CI / pipe / log
+    /// file), so nothing animates into a non-TTY sink.
+    pub logs: bool,
+}
+
+impl RenderPrefs {
+    /// Detect render preferences from the live environment via `hm-render`'s
+    /// shared TTY/color helpers — the single source of truth, also used by
+    /// `hm/src/context.rs`. This inspects `NO_COLOR` and the stdout/stderr
+    /// TTY state at call time, so it is a deliberate observation of the
+    /// environment rather than a constant default.
+    #[must_use]
+    pub fn detect() -> Self {
+        Self {
+            color: hm_render::color_enabled(false),
+            logs: hm_render::stdout_piped(),
+        }
+    }
 }
 
 /// Map a raw generated-client error into an `anyhow` error with a readable

crates/hm-plugin-cloud/src/verbs/build.rs

@@ -56,8 +56,8 @@ async fn watch(client: &HarmontClient, org: &str, pipe: &str, number: i64) -> Re
     // Render the live build through the shared `hm-render` renderers (the same
     // ones a local `hm run` uses), driven by the `BuildEvent`s `watch_build`
     // emits over an mpsc channel.
-    let (color, logs) = crate::settings::render_prefs();
-    let renderer = hm_render::renderer_for("human", color, logs)?;
+    let prefs = crate::settings::RenderPrefs::detect();
+    let renderer = hm_render::renderer_for("human", prefs.color, prefs.logs)?;
     let (tx, rx) = tokio::sync::mpsc::channel(1024);
     let driver = tokio::spawn(hm_render::drive(renderer, rx));
 

crates/hm-plugin-cloud/src/verbs/job.rs

@@ -69,10 +69,10 @@ async fn log_cmd(
     let token = client.log_token(org, pipe, build).await?;
     let log_base = client.base_url().to_string();
 
-    let (color, _logs) = settings::render_prefs();
+    let prefs = settings::RenderPrefs::detect();
     // A single-job tail is always a flat log stream, so force the streaming
     // HumanRenderer (logs = true) regardless of TTY.
-    let renderer = hm_render::renderer_for("human", color, true)?;
+    let renderer = hm_render::renderer_for("human", prefs.color, true)?;
     let (tx, rx) = tokio::sync::mpsc::channel(1024);
     let driver = tokio::spawn(hm_render::drive(renderer, rx));