Merge remote-tracking branch 'origin/main' into chore/get-a-vm-running

# Conflicts:
#	lib/hyper/node/img/mutable.ex
#	lib/hyper/node/img/server.ex
#	lib/hyper/node/img/thin_pool.ex
#	lib/hyper/node/layer/server.ex
#	lib/mix/tasks/suidhelper.install.ex

Author: markovejnovic

lib/hyper/node/img/mutable.ex

@@ -121,9 +121,17 @@ defmodule Hyper.Node.Img.Mutable do
 
   @impl true
   # Each privileged command runs through `System.cmd`, which links a transient
-  # port to this process; because we trap exits (for `terminate/2` teardown),
-  # the port's normal close is delivered here. Ignore it.
-  def handle_info({:EXIT, _port, :normal}, state), do: {:noreply, state}
+  # port to this process and returns only once that command has finished. Because
+  # we trap exits (for `terminate/2` teardown), the now-defunct port's exit lands
+  # here afterwards -- stale by construction, whatever its reason -- so ignore it.
+  def handle_info({:EXIT, port, _reason}, state) when is_port(port), do: {:noreply, state}
+
+  @impl true
+  # No process is deliberately linked here beyond those transient command ports,
+  # so a linked *process* EXIT is a genuine fault: propagate its reason (so
+  # terminate/2 still runs teardown) rather than crash opaquely on an unmatched
+  # message.
+  def handle_info({:EXIT, _pid, reason}, state), do: {:stop, reason, state}
 
   @impl true
   def terminate(_reason, state) do

lib/hyper/node/img/server.ex

@@ -130,9 +130,17 @@ defmodule Hyper.Node.Img.Server do
 
   @impl true
   # Each privileged command runs through `System.cmd`, which links a transient
-  # port to this process; because we trap exits (for `terminate/2` teardown),
-  # the port's normal close is delivered here. Ignore it.
-  def handle_info({:EXIT, _port, :normal}, state), do: {:noreply, state}
+  # port to this process and returns only once that command has finished. Because
+  # we trap exits (for `terminate/2` teardown), the now-defunct port's exit lands
+  # here afterwards -- stale by construction, whatever its reason -- so ignore it.
+  def handle_info({:EXIT, port, _reason}, state) when is_port(port), do: {:noreply, state}
+
+  @impl true
+  # No process is deliberately linked here beyond those transient command ports,
+  # so a linked *process* EXIT is a genuine fault: propagate its reason (so
+  # terminate/2 still runs teardown) rather than crash opaquely on an unmatched
+  # message.
+  def handle_info({:EXIT, _pid, reason}, state), do: {:stop, reason, state}
 
   @impl true
   def terminate(_reason, %State{dm_names: dm_names}) do

lib/hyper/node/img/thin_pool.ex

@@ -96,10 +96,17 @@ defmodule Hyper.Node.Img.ThinPool do
 
   @impl true
   # Each privileged command runs through `System.cmd`, which links a transient
-  # port to this process; because we trap exits (for `terminate/2` teardown),
-  # the port's normal close is delivered here. Ignore it. An abnormal exit
-  # carries a non-`:normal` reason and falls through to the default handler.
-  def handle_info({:EXIT, _port, :normal}, state), do: {:noreply, state}
+  # port to this process and returns only once that command has finished. Because
+  # we trap exits (for `terminate/2` teardown), the now-defunct port's exit lands
+  # here afterwards -- stale by construction, whatever its reason -- so ignore it.
+  def handle_info({:EXIT, port, _reason}, state) when is_port(port), do: {:noreply, state}
+
+  @impl true
+  # No process is deliberately linked here beyond those transient command ports,
+  # so a linked *process* EXIT is a genuine fault: propagate its reason (so
+  # terminate/2 still runs teardown) rather than crash opaquely on an unmatched
+  # message.
+  def handle_info({:EXIT, _pid, reason}, state), do: {:stop, reason, state}
 
   @impl true
   def terminate(_reason, state) do

lib/hyper/node/layer/server.ex

@@ -121,9 +121,17 @@ defmodule Hyper.Node.Layer.Server do
 
   @impl true
   # Each privileged command runs through `System.cmd`, which links a transient
-  # port to this process; because we trap exits (for `terminate/2` teardown),
-  # the port's normal close is delivered here. Ignore it.
-  def handle_info({:EXIT, _port, :normal}, state), do: {:noreply, state}
+  # port to this process and returns only once that command has finished. Because
+  # we trap exits (for `terminate/2` teardown), the now-defunct port's exit lands
+  # here afterwards -- stale by construction, whatever its reason -- so ignore it.
+  def handle_info({:EXIT, port, _reason}, state) when is_port(port), do: {:noreply, state}
+
+  @impl true
+  # No process is deliberately linked here beyond those transient command ports,
+  # so a linked *process* EXIT is a genuine fault: propagate its reason (so
+  # terminate/2 still runs teardown) rather than crash opaquely on an unmatched
+  # message.
+  def handle_info({:EXIT, _pid, reason}, state), do: {:stop, reason, state}
 
   @impl true
   def terminate(_reason, %State{blk_path: blk_path}) do

lib/mix/tasks/suidhelper.install.ex

@@ -29,7 +29,7 @@ defmodule Mix.Tasks.Suidhelper.Install do
 
   @helper_dir "native/suidhelper"
   @source Path.join(@helper_dir, "target/release/hyper-suidhelper")
-  # Must match `Hyper.Config`'s default `suid_helper` path and the xtask's
+  # Must match `Hyper.Cfg.Tools.suidhelper/0`'s default path and the xtask's
   # `INSTALL_PATH`: a `PATH` location the unprivileged node can exec.
   @install_path "/usr/local/bin/hyper-suidhelper"