Merge remote-tracking branch 'origin/main' into feat/sqlite-image-graph-backend

# Conflicts:
#	mix.lock

Author: markovejnovic

.github/workflows/ci.yml

@@ -87,14 +87,22 @@ jobs:
           mix ecto.create -r Hyper.Img.Db.Repo.Postgres
           mix ecto.migrate -r Hyper.Img.Db.Repo.Postgres
 
-      - name: Test (warnings as errors)
+      - name: Test + coverage (warnings as errors)
         env:
           MIX_ENV: test
-        # --no-start: the app's supervision tree boots Hyper.Node, which provisions
-        # a real Firecracker host under /srv/hyper -- unavailable (and unprivileged)
-        # on a CI runner. This matches how the suite is run in development; tests
-        # that need the Repo start it themselves against the DB created above.
-        run: mix test --no-start --warnings-as-errors
+        # coveralls.json wraps `mix test` (so --no-start / --warnings-as-errors
+        # still apply) and writes cover/excoveralls.json for the Codecov upload.
+        # --no-start: the supervision tree provisions a real Firecracker host
+        # under /srv/hyper, unavailable on a CI runner.
+        run: mix coveralls.json --no-start --warnings-as-errors
+
+      - name: Upload coverage to Codecov
+        uses: codecov/codecov-action@v5
+        with:
+          token: ${{ secrets.CODECOV_TOKEN }}
+          files: cover/excoveralls.json
+          flags: elixir
+          fail_ci_if_error: true
 
       - name: Dialyzer
         run: mix dialyzer
@@ -123,5 +131,19 @@ jobs:
       - name: clippy
         run: cargo clippy --all-targets --all-features -- -D warnings
 
-      - name: test
-        run: cargo test --all-features
+      - name: Install cargo-llvm-cov
+        uses: taiki-e/install-action@v2
+        with:
+          tool: cargo-llvm-cov
+
+      - name: test + coverage
+        run: cargo llvm-cov --all-features --lcov --output-path lcov.info
+
+      - name: Upload coverage to Codecov
+        uses: codecov/codecov-action@v5
+        with:
+          token: ${{ secrets.CODECOV_TOKEN }}
+          # working-directory only applies to `run:` steps, not actions.
+          files: native/suidhelper/lcov.info
+          flags: rust
+          fail_ci_if_error: true

README.md

@@ -7,6 +7,7 @@
   <a href="https://hexdocs.pm/hypervm/"><img src="https://img.shields.io/badge/docs-hexdocs-purple.svg" alt="Hexdocs" /></a>
   <a href="LICENSE"><img src="https://img.shields.io/hexpm/l/hypervm.svg" alt="License: AGPL-3.0" /></a>
   <a href="https://github.com/harmont-dev/hyper/commits/main"><img src="https://img.shields.io/github/last-commit/harmont-dev/hyper.svg" alt="Last commit" /></a>
+  <a href="https://codecov.io/gh/harmont-dev/hyper"><img src="https://codecov.io/gh/harmont-dev/hyper/branch/main/graph/badge.svg" alt="Coverage" /></a>
   <a href="https://discord.gg/hm-dev"><img src="https://img.shields.io/discord/1503184719578136576?logo=discord&label=discord" alt="Discord" /></a>
   <img src="https://img.shields.io/badge/elixir-~%3E%201.20-4B275F.svg" alt="Elixir ~> 1.20" />
 </p>
@@ -50,7 +51,7 @@ deploying and integrating Hyper.
   [BEAM](https://en.wikipedia.org/wiki/BEAM_(Erlang_virtual_machine)). This
   means that fault-tolerance is built into the virtual machine, and allows you
   to interactively debug any issues you run into.
-- gRPC Interface -- although the author exclusively uses Hyper through the
+- **gRPC Interface** -- although the author exclusively uses Hyper through the
   BEAM-native interfaces, we recognize this may not be ideal for all languages
   and existing stacks. For that reason, Hyper has a GRPC interface, so you can
   call it from any language you already use.

codecov.yml

@@ -0,0 +1,36 @@
+# Codecov configuration for the hyper monorepo. Two components upload under
+# distinct flags from separate CI jobs (see .github/workflows/ci.yml):
+#   elixir -> cover/excoveralls.json   (ExCoveralls / mix coveralls.json)
+#   rust   -> native/suidhelper/lcov.info  (cargo llvm-cov)
+coverage:
+  status:
+    project:
+      default:
+        target: auto
+        # Don't fail PRs on coverage deltas yet (early-stage project).
+        informational: true
+    patch:
+      default:
+        informational: true
+
+flags:
+  elixir:
+    paths:
+      - lib/
+    carryforward: true
+  rust:
+    paths:
+      - native/suidhelper/src/
+    carryforward: true
+
+# Generated bindings, deps, and test code never count toward coverage.
+ignore:
+  - "lib/hyper/firecracker/api/operations"
+  - "lib/hyper/firecracker/api/schemas"
+  - "test"
+  - "deps"
+  - "native/suidhelper/target"
+
+comment:
+  layout: "reach, flags, files"
+  require_changes: false

coveralls.json

@@ -0,0 +1,6 @@
+{
+  "skip_files": [
+    "lib/hyper/firecracker/api/operations/",
+    "lib/hyper/firecracker/api/schemas/"
+  ]
+}

mix.exs

@@ -15,6 +15,7 @@ defmodule Hyper.MixProject do
       # the only hook that also fires when hyper is compiled AS A DEPENDENCY.
       compilers: [:firecracker_gen | Mix.compilers()],
       deps: deps(),
+      test_coverage: [tool: ExCoveralls],
       docs: docs(),
       package: package(),
       aliases: aliases(),
@@ -28,6 +29,18 @@ defmodule Hyper.MixProject do
     ]
   end
 
+  # Run the coverage tasks in :test so test-only deps (excoveralls) load and the
+  # Repo-backed tests see the test database. Mirrors how `mix test` selects :test.
+  def cli do
+    [
+      preferred_envs: [
+        coveralls: :test,
+        "coveralls.json": :test,
+        "coveralls.html": :test
+      ]
+    ]
+  end
+
   # Run "mix help compile.app" to learn about applications.
   def application do
     [
@@ -43,6 +56,7 @@ defmodule Hyper.MixProject do
   defp deps do
     [
       {:credo, "~> 1.7", only: [:dev, :test], runtime: false},
+      {:excoveralls, "~> 0.18", only: :test, runtime: false},
       {:dialyxir, "~> 1.4", only: [:dev], runtime: false},
       {:ex_doc, "~> 0.34", only: :dev, runtime: false},
       {:ecto_sql, "~> 3.13"},

mix.lock

@@ -17,6 +17,7 @@
   "elixir_make": {:hex, :elixir_make, "0.10.0", "16577e2583a79bb79237bbff349619ef5d80afffc07eac6e4faf0d00e2ddaf7d", [:mix], [], "hexpm", "dc1f09fb7fa68866b886abd5f0f3c83553b1a19a52359a899e92af1bb3b31982"},
   "erlex": {:hex, :erlex, "0.2.9", "7debbbaa9f4f368b8cd648983e0f1d7963028508e9c59e9d4ed504e94ef52a55", [:mix], [], "hexpm", "8cfffc0ec7159e6d73de2ab28a588064de80f88b2798d5cbe4482cbbc200178b"},
   "ex_doc": {:hex, :ex_doc, "0.40.3", "4a972ffe64bc07dc605af487e98fc19b72a4185f55ca031b94c0552d6071c1d9", [:mix], [{:earmark_parser, "~> 1.4.44", [hex: :earmark_parser, repo: "hexpm", optional: false]}, {:makeup_c, ">= 0.1.0", [hex: :makeup_c, repo: "hexpm", optional: true]}, {:makeup_elixir, "~> 0.14 or ~> 1.0", [hex: :makeup_elixir, repo: "hexpm", optional: false]}, {:makeup_erlang, "~> 0.1 or ~> 1.0", [hex: :makeup_erlang, repo: "hexpm", optional: false]}, {:makeup_html, ">= 0.1.0", [hex: :makeup_html, repo: "hexpm", optional: true]}], "hexpm", "2756e357742fecd9749b489b85d67c9ce99c465f2e75728d9e6dc8d704b973de"},
+  "excoveralls": {:hex, :excoveralls, "0.18.5", "e229d0a65982613332ec30f07940038fe451a2e5b29bce2a5022165f0c9b157e", [:mix], [{:castore, "~> 1.0", [hex: :castore, repo: "hexpm", optional: true]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "523fe8a15603f86d64852aab2abe8ddbd78e68579c8525ae765facc5eae01562"},
   "exqlite": {:hex, :exqlite, "0.37.0", "701e7e02679e8c1bb6da331ea93d83b481c714b0831e82e2f8a73375b3d93a9e", [:make, :mix], [{:cc_precompiler, "~> 0.1", [hex: :cc_precompiler, repo: "hexpm", optional: false]}, {:db_connection, "~> 2.1", [hex: :db_connection, repo: "hexpm", optional: false]}, {:elixir_make, "~> 0.8", [hex: :elixir_make, repo: "hexpm", optional: false]}, {:table, "~> 0.1.0", [hex: :table, repo: "hexpm", optional: true]}], "hexpm", "a44816dd0d234fba68c47a3609af61d306d24ef517a89bfaee4d6a811792d913"},
   "file_system": {:hex, :file_system, "1.1.1", "31864f4685b0148f25bd3fbef2b1228457c0c89024ad67f7a81a3ffbc0bbad3a", [:mix], [], "hexpm", "7a15ff97dfe526aeefb090a7a9d3d03aa907e100e262a0f8f7746b78f8f87a5d"},
   "finch": {:hex, :finch, "0.23.0", "e3f9287ac25a8832f848b144c2b57346aac65b205e2e0629a52adfe6507fd837", [:mix], [{:mime, "~> 1.0 or ~> 2.0", [hex: :mime, repo: "hexpm", optional: false]}, {:mint, "~> 1.8", [hex: :mint, repo: "hexpm", optional: false]}, {:nimble_options, "~> 0.4 or ~> 1.0", [hex: :nimble_options, repo: "hexpm", optional: false]}, {:nimble_pool, "~> 1.1", [hex: :nimble_pool, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "80e58d3f936f57e3fdf404f83a3642897ae6d9fb642934e46da4d8fe761b99d5"},

native/suidhelper/.gitignore

@@ -1 +1,2 @@
 /target
+/lcov.info

native/suidhelper/rust-toolchain.toml

@@ -8,4 +8,4 @@ channel = "nightly"
 targets = ["x86_64-unknown-linux-musl", "aarch64-unknown-linux-musl"]
 # Pin the lint/format tooling so `cargo fmt`/`cargo clippy` auto-install it
 # (rustup honors this file in CI and locally).
-components = ["clippy", "rustfmt"]
+components = ["clippy", "rustfmt", "llvm-tools-preview"]

native/suidhelper/src/util/safe_path.rs

@@ -20,8 +20,10 @@ pub enum ValidationError {
 }
 
 /// Absoluteness axis: require an absolute path.
+#[derive(Debug)]
 pub struct IsAbsolute;
 /// Components axis: reject `.`, `..`, and empty components.
+#[derive(Debug)]
 pub struct StrictComponents;
 
 /// Absoluteness axis.
@@ -59,6 +61,7 @@ impl Components for StrictComponents {
 }
 
 /// A `PathBuf` proven to satisfy the lexical axes named by its type parameters.
+#[derive(Debug)]
 pub struct SafePath<A, S>(PathBuf, PhantomData<(A, S)>);
 
 impl<A> SafePath<A, StrictComponents> {