Skip to content

Commit f830121

Browse files
committed
test(firecracker): round-trip all 9 Drive fields; drop gc Internals banner
Final-review polish: extend the codec property generator to exercise io_engine/partuuid/socket (were never generated), and delete the pre-existing '## Internals' banner in gc.ex (no-banner rule) while the file is already open from the Gc.Prune extraction.
1 parent 176e67e commit f830121

2 files changed

Lines changed: 6 additions & 2 deletions

File tree

lib/hyper/img/db/gc.ex

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,8 +118,6 @@ defmodule Hyper.Img.Db.Gc do
118118
# role, monitor noise, etc.) rather than crashing an in-flight sweep.
119119
def handle_info(_msg, state), do: {:noreply, state}
120120

121-
## Internals
122-
123121
@spec acquire(t()) :: t()
124122
defp acquire(state) do
125123
case Horde.Registry.register(Routing.name(), @singleton_key, nil) do

test/hyper/firecracker/api/codec_properties_test.exs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,9 @@ defmodule Hyper.Firecracker.Api.CodecPropertiesTest do
4040
is_read_only <- optional(boolean()),
4141
path_on_host <- optional(string(:alphanumeric, min_length: 1)),
4242
cache_type <- optional(member_of(["Unsafe", "Writeback"])),
43+
io_engine <- optional(member_of(["Sync", "Async"])),
44+
partuuid <- optional(string(:alphanumeric, min_length: 1)),
45+
socket <- optional(string(:alphanumeric, min_length: 1)),
4346
rate_limiter <- optional(rate_limiter())
4447
) do
4548
%Drive{
@@ -48,6 +51,9 @@ defmodule Hyper.Firecracker.Api.CodecPropertiesTest do
4851
is_read_only: is_read_only,
4952
path_on_host: path_on_host,
5053
cache_type: cache_type,
54+
io_engine: io_engine,
55+
partuuid: partuuid,
56+
socket: socket,
5157
rate_limiter: rate_limiter
5258
}
5359
end

0 commit comments

Comments
 (0)