Scope Discovery: Custom Kad-DHT + Connection Gating#4939
Draft
joycaleb9705 wants to merge 2 commits into
Draft
Conversation
Collaborator
|
Hey, tests are failing with p2p/host.go:394:31: cannot use disc.GetRawDiscovery() (value of type []"github.com/libp2p/go-libp2p/core/discovery".Discovery) as "github.com/libp2p/go-libp2p/core/discovery".Discovery value in argument to libp2p_pubsub.WithDiscovery: []"github.com/libp2p/go-libp2p/core/discovery".Discovery does not implement "github.com/libp2p/go-libp2p/core/discovery".Discovery (missing method Advertise) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems
EOF.Rationale
A custom Kad-DHT protocol prefix isolates our routing table from the public DHT and keeps discovery Harmony-only.
Connection gating blocks or immediately tears down non-Harmony peers at the transport layer (pre-dial/accept and post-identify), preserving capacity for legitimate Harmony traffic.
Changes
/harmony/kad/1.0.0) and use only configured Harmony bootnodes.Notes:
No changes to PubSub topics, scoring, or connmgr here (follow-ups if needed).
Rollout
Success criteria