-
Notifications
You must be signed in to change notification settings - Fork 0
Rename memdb VFS option to memory and bump package version #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -52,7 +52,7 @@ async function initDatabase(config: SQLiteWASMConfig) { | |
| } else if (vfsType === 'opfs') { | ||
| // Direct OPFS VFS (if available) | ||
| PoolUtil = sqlite3.opfs || null; | ||
| } else if (vfsType === 'memdb') { | ||
| } else if (vfsType === 'memory') { | ||
| // In-memory database | ||
| PoolUtil = null; | ||
| } | ||
|
|
@@ -69,7 +69,7 @@ async function openDatabase(filename: string) { | |
| flags: 'create', | ||
| vfs: 'opfs-sahpool', | ||
| }); | ||
| } else if (vfsType === 'memdb') { | ||
| } else if (vfsType === 'memory') { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Changing the VFS discriminator to Useful? React with 👍 / 👎. |
||
| db = new sqlite3.oo1.DB(':memory:', 'c'); | ||
| } else { | ||
| // Check if OpfsDb is available (requires COOP/COEP headers) | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change intentionally introduces a backwards-incompatible API rename (
memdbtomemory) but only bumps the package from0.2.5to0.2.6. Consumers using a range like^0.2.5will receive this as a routine patch update even though it can break runtime behavior, so this should be released as a new minor version (for pre-1.0,0.3.0) or kept backward-compatible.Useful? React with 👍 / 👎.