|
| 1 | +package app |
| 2 | + |
| 3 | +import ( |
| 4 | + "net/http" |
| 5 | + "testing" |
| 6 | + |
| 7 | + gitlab "gitlab.com/gitlab-org/api/client-go" |
| 8 | +) |
| 9 | + |
| 10 | +type fakeMergeRequestRebaserClient struct { |
| 11 | + testBase |
| 12 | + rebaseInProgressCount int // number of times to return RebaseInProgress: true |
| 13 | + getMergeRequestCalls int // tracks how many times GetMergeRequest was called |
| 14 | +} |
| 15 | + |
| 16 | +func (f *fakeMergeRequestRebaserClient) RebaseMergeRequest(pid interface{}, mergeRequest int64, opt *gitlab.RebaseMergeRequestOptions, options ...gitlab.RequestOptionFunc) (*gitlab.Response, error) { |
| 17 | + resp, err := f.handleGitlabError() |
| 18 | + if err != nil { |
| 19 | + return nil, err |
| 20 | + } |
| 21 | + |
| 22 | + return resp, err |
| 23 | +} |
| 24 | + |
| 25 | +func (f *fakeMergeRequestRebaserClient) GetMergeRequest(pid interface{}, mergeRequest int64, opt *gitlab.GetMergeRequestsOptions, options ...gitlab.RequestOptionFunc) (*gitlab.MergeRequest, *gitlab.Response, error) { |
| 26 | + resp, err := f.handleGitlabError() |
| 27 | + if err != nil { |
| 28 | + return nil, nil, err |
| 29 | + } |
| 30 | + |
| 31 | + f.getMergeRequestCalls++ |
| 32 | + rebaseInProgress := f.getMergeRequestCalls <= f.rebaseInProgressCount |
| 33 | + |
| 34 | + return &gitlab.MergeRequest{RebaseInProgress: rebaseInProgress}, resp, err |
| 35 | +} |
| 36 | + |
| 37 | +func TestRebaseHandler(t *testing.T) { |
| 38 | + var testRebaseMrPayload = RebaseMrRequest{SkipCI: false} |
| 39 | + t.Run("Rebases merge request when rebase completes immediately", func(t *testing.T) { |
| 40 | + request := makeRequest(t, http.MethodPost, "/mr/rebase", testRebaseMrPayload) |
| 41 | + fakeClient := &fakeMergeRequestRebaserClient{rebaseInProgressCount: 0} |
| 42 | + svc := middleware( |
| 43 | + mergeRequestRebaserService{testProjectData, fakeClient}, |
| 44 | + withMr(testProjectData, fakeMergeRequestLister{}), |
| 45 | + withPayloadValidation(methodToPayload{ |
| 46 | + http.MethodPost: newPayload[RebaseMrRequest], |
| 47 | + }), |
| 48 | + withMethodCheck(http.MethodPost), |
| 49 | + ) |
| 50 | + data := getSuccessData(t, svc, request) |
| 51 | + assert(t, data.Message, "MR rebased on server") |
| 52 | + assert(t, fakeClient.getMergeRequestCalls, 1) |
| 53 | + }) |
| 54 | + t.Run("Rebases merge request and polls until rebase completes", func(t *testing.T) { |
| 55 | + request := makeRequest(t, http.MethodPost, "/mr/rebase", testRebaseMrPayload) |
| 56 | + fakeClient := &fakeMergeRequestRebaserClient{rebaseInProgressCount: 1} |
| 57 | + svc := middleware( |
| 58 | + mergeRequestRebaserService{testProjectData, fakeClient}, |
| 59 | + withMr(testProjectData, fakeMergeRequestLister{}), |
| 60 | + withPayloadValidation(methodToPayload{ |
| 61 | + http.MethodPost: newPayload[RebaseMrRequest], |
| 62 | + }), |
| 63 | + withMethodCheck(http.MethodPost), |
| 64 | + ) |
| 65 | + data := getSuccessData(t, svc, request) |
| 66 | + assert(t, data.Message, "MR rebased on server") |
| 67 | + assert(t, fakeClient.getMergeRequestCalls, 2) |
| 68 | + }) |
| 69 | + var testRebaseMrPayloadSkipCI = RebaseMrRequest{SkipCI: true} |
| 70 | + t.Run("Rebases merge request and skips CI", func(t *testing.T) { |
| 71 | + request := makeRequest(t, http.MethodPost, "/mr/rebase", testRebaseMrPayloadSkipCI) |
| 72 | + fakeClient := &fakeMergeRequestRebaserClient{} |
| 73 | + svc := middleware( |
| 74 | + mergeRequestRebaserService{testProjectData, fakeClient}, |
| 75 | + withMr(testProjectData, fakeMergeRequestLister{}), |
| 76 | + withPayloadValidation(methodToPayload{ |
| 77 | + http.MethodPost: newPayload[RebaseMrRequest], |
| 78 | + }), |
| 79 | + withMethodCheck(http.MethodPost), |
| 80 | + ) |
| 81 | + data := getSuccessData(t, svc, request) |
| 82 | + assert(t, data.Message, "MR rebased on server (skipping CI)") |
| 83 | + }) |
| 84 | + t.Run("Handles errors from Gitlab client", func(t *testing.T) { |
| 85 | + request := makeRequest(t, http.MethodPost, "/mr/rebase", testRebaseMrPayload) |
| 86 | + svc := middleware( |
| 87 | + mergeRequestRebaserService{testProjectData, &fakeMergeRequestRebaserClient{testBase: testBase{errFromGitlab: true}}}, |
| 88 | + withMr(testProjectData, fakeMergeRequestLister{}), |
| 89 | + withPayloadValidation(methodToPayload{ |
| 90 | + http.MethodPost: newPayload[RebaseMrRequest], |
| 91 | + }), |
| 92 | + withMethodCheck(http.MethodPost), |
| 93 | + ) |
| 94 | + data, _ := getFailData(t, svc, request) |
| 95 | + checkErrorFromGitlab(t, data, "Could not rebase MR") |
| 96 | + }) |
| 97 | + t.Run("Handles non-200s from Gitlab", func(t *testing.T) { |
| 98 | + request := makeRequest(t, http.MethodPost, "/mr/rebase", testRebaseMrPayload) |
| 99 | + svc := middleware( |
| 100 | + mergeRequestRebaserService{testProjectData, &fakeMergeRequestRebaserClient{testBase: testBase{status: http.StatusSeeOther}}}, |
| 101 | + withMr(testProjectData, fakeMergeRequestLister{}), |
| 102 | + withPayloadValidation(methodToPayload{ |
| 103 | + http.MethodPost: newPayload[RebaseMrRequest], |
| 104 | + }), |
| 105 | + withMethodCheck(http.MethodPost), |
| 106 | + ) |
| 107 | + data, _ := getFailData(t, svc, request) |
| 108 | + checkNon200(t, data, "Could not rebase MR", "/mr/rebase") |
| 109 | + }) |
| 110 | +} |
0 commit comments