Full audit: dedup fix, PV tests, README rewrite, release workflow#5
Merged
Conversation
Focus on how users plug behavioral memory into their own agent (OpenAI, Google, Ollama examples). De-emphasize reference agent to a single line. Remove redundant sections, cut length by ~60%. Co-authored-by: Cursor <cursoragent@cursor.com>
Critical fixes: - Wire ORCHESTRATION_PARAMS as documented constant, clarify routing - Add 29 unit tests for lenient PV matching (SQL, text, structure) - Move typer to core deps (CLI entry point requires it at import) Correctness fixes: - Fix pgvector dedup: convert cosine distance to similarity (1 - dist) so the 0.95 threshold works correctly with both store backends - Fix _sql_structural_match docstring (table overlap only, not aggregates) Documentation: - Add README sections: register custom schemas, non-LangChain usage, persistence limitations, MCP schema loading - Add SANDBOX_TIMEOUT_SECONDS to .env.example - Add make targets to CONTRIBUTING.md - Clarify agent/tools/mcp_tools.py as example stub code Tests: 133 passing (up from 104) Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Commits that were pushed to the branch after PR #4 was merged early, plus release workflow fix.
contents: readpermission and explicitdist/path for PyPI trusted publishingChanges
README.md— rewritten from scratch, integration-focusedsrc/behavioral_memory/evaluation/metrics.py— ORCHESTRATION_PARAMS documented, SQL docstring fixedsrc/behavioral_memory/memory/store.py— similarity_score() converts distance to similaritysrc/behavioral_memory/memory/dedup.py— docstring updatedtests/unit/test_metrics.py— 29 new tests (133 total)pyproject.toml— typer in core deps.github/workflows/release.yml— permissions + dist path.env.example,CONTRIBUTING.md,.gitignore,agent/tools/mcp_tools.py— polishTest plan
Made with Cursor