Commit 780e7a0
fix(wdio-browserstack-service): exclude
The accessibility command wrapper is declared async, so wrapping
WebdriverIO's synchronous `browser.action()` turned its return value into
a Promise — breaking `browser.action(...).move()` / `.down()`, and
therefore `browser.moveTo()` and `browser.keys(Key.Tab)`, which are built
on top of `action()`. With `accessibility: true` users saw
"browser.action(...).move is not a function" / "keyAction.down is not a
function"; the same code works with accessibility disabled.
Exclude `action` (the only synchronous chainable command) from wrapping
in both install sites (direct flow + CLI/gRPC flow). Already-async
commands (`keys`, `actions`, `moveTo`) stay wrapped, so accessibility
scan coverage is unchanged.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>action from a11y command wrapping (SDK-6265)1 parent 98ba397 commit 780e7a0
3 files changed
Lines changed: 20 additions & 0 deletions
File tree
- packages/wdio-browserstack-service/src
- cli/modules
Lines changed: 5 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
| 76 | + | |
76 | 77 | | |
77 | 78 | | |
78 | 79 | | |
| |||
254 | 255 | | |
255 | 256 | | |
256 | 257 | | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
257 | 262 | | |
258 | 263 | | |
259 | 264 | | |
| |||
Lines changed: 5 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| 16 | + | |
16 | 17 | | |
17 | 18 | | |
18 | 19 | | |
| |||
138 | 139 | | |
139 | 140 | | |
140 | 141 | | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
141 | 146 | | |
142 | 147 | | |
143 | 148 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
65 | 75 | | |
66 | 76 | | |
67 | 77 | | |
| |||
0 commit comments