refactor(strip): let the strip_text themeable own text rotation

Author: has2k1

plotnine/_mpl/text.py

@@ -25,20 +25,18 @@ def __init__(
         ax: Axes,
         position: StripPosition,
         label: str,
-        rotation: float,
     ):
         self.position = position
         is_oneline = len(label.split("\n")) == 1
         kwargs = {
-            "rotation": rotation,
             "transform": ax.transAxes,
             "clip_on": False,
             "zorder": 3.3,
-            # Since the text can be rotated, it is simpler to anchor it at
-            # the center, align it, then do the rotation. Vertically,
-            # center_baseline places the text in the visual center, but
-            # only if it is one line. For multiline text, we are better
-            # off with plain center.
+            # The strip_text themeable rotates the text. We anchor it at
+            # the center so that alignment holds under any rotation it
+            # applies. Vertically, center_baseline places the text in the
+            # visual center, but only if it is one line. For multiline
+            # text, we are better off with plain center.
             "ha": "center",
             "va": "center_baseline" if is_oneline else "center",
             "rotation_mode": "anchor",

plotnine/facets/strips.py

@@ -57,18 +57,13 @@ def draw(self):
 
         from .._mpl.text import StripText
 
-        theme = self.theme
-        targets = theme.targets
+        targets = self.theme.targets
         position = self.position
 
-        if position == "top":
-            rotation = theme.getp(("strip_text_x", "rotation"))
-        elif position == "right":
-            rotation = theme.getp(("strip_text_y", "rotation"))
-        else:
+        if position not in ("top", "right"):
             raise ValueError(f"Unknown position for strip text: {position!r}")
 
-        text = StripText(self.ax, position, self.label_info.text(), rotation)
+        text = StripText(self.ax, position, self.label_info.text())
         rect = text.patch
 
         figure = self.facet.plot.figure