Use helper functions to adjust the plot footer

Author: has2k1

plotnine/_mpl/layout_manager/_composition_layout_items.py

@@ -8,6 +8,8 @@
 from plotnine._mpl.utils import (
     ArtistGeometry,
     TextJustifier,
+    resize_footer_background,
+    resize_footer_line,
 )
 
 if TYPE_CHECKING:
@@ -102,30 +104,18 @@ def _move_artists(self, spaces: CompositionSideSpaces):
             justify.horizontally_about(
                 self.plot_footer, ha, plot_footer_position
             )
-            self._resize_plot_footer_background(spaces)
-            self._resize_plot_footer_line(spaces)
-
-    def _resize_plot_footer_background(self, spaces: CompositionSideSpaces):
-        """
-        Resize the plot footer to the size of the footer
-        """
-        if not self.plot_footer_background:
-            return
-
-        self.plot_footer_background.set_x(spaces.l.offset)
-        self.plot_footer_background.set_y(spaces.b.offset)
-        self.plot_footer_background.set_height(spaces.b.footer_height)
-        self.plot_footer_background.set_width(spaces.plot_width)
-
-    def _resize_plot_footer_line(self, spaces: CompositionSideSpaces):
-        """
-        Resize the footer line to be a border above the footer
-        """
-        if not self.plot_footer_line:
-            return
-
-        x1 = spaces.l.offset
-        x2 = x1 + spaces.plot_width
-        y1 = y2 = spaces.b.offset + spaces.b.footer_height
-        self.plot_footer_line.set_xdata([x1, x2])
-        self.plot_footer_line.set_ydata([y1, y2])
+            if self.plot_footer_background:
+                resize_footer_background(
+                    self.plot_footer_background,
+                    x=spaces.l.offset,
+                    y=spaces.b.offset,
+                    height=spaces.b.footer_height,
+                    width=spaces.plot_width,
+                )
+            if self.plot_footer_line:
+                resize_footer_line(
+                    self.plot_footer_line,
+                    x=spaces.l.offset,
+                    width=spaces.plot_width,
+                    y=spaces.b.offset + spaces.b.footer_height,
+                )

plotnine/_mpl/layout_manager/_plot_layout_items.py

@@ -13,6 +13,8 @@
     TextJustifier,
     get_subplotspecs,
     rel_position,
+    resize_footer_background,
+    resize_footer_line,
 )
 
 if TYPE_CHECKING:
@@ -395,8 +397,21 @@ def _move_artists(self, spaces: PlotSideSpaces):
             justify.horizontally_about(
                 self.plot_footer, ha, plot_footer_position
             )
-            self._resize_plot_footer_background(spaces)
-            self._resize_plot_footer_line(spaces)
+            if self.plot_footer_background:
+                resize_footer_background(
+                    self.plot_footer_background,
+                    x=spaces.l.offset,
+                    y=spaces.b.offset,
+                    height=spaces.b.footer_height,
+                    width=spaces.plot_width,
+                )
+            if self.plot_footer_line:
+                resize_footer_line(
+                    self.plot_footer_line,
+                    x=spaces.l.offset,
+                    width=spaces.plot_width,
+                    y=spaces.b.offset + spaces.b.footer_height,
+                )
 
         if self.axis_title_x:
             ha = theme.getp(("axis_title_x", "ha"), "center")
@@ -532,31 +547,6 @@ def _strip_text_y_background_equal_widths(self):
         for text, scale in zip(self.strip_text_y, relative_widths):
             text.patch.expand = scale
 
-    def _resize_plot_footer_background(self, spaces: PlotSideSpaces):
-        """
-        Resize the plot footer to the size of the footer
-        """
-        if not self.plot_footer_background:
-            return
-
-        self.plot_footer_background.set_x(spaces.l.offset)
-        self.plot_footer_background.set_y(spaces.b.offset)
-        self.plot_footer_background.set_height(spaces.b.footer_height)
-        self.plot_footer_background.set_width(spaces.plot_width)
-
-    def _resize_plot_footer_line(self, spaces: PlotSideSpaces):
-        """
-        Resize the footer line to be a border above the footer
-        """
-        if not self.plot_footer_line:
-            return
-
-        x1 = spaces.l.offset
-        x2 = x1 + spaces.plot_width
-        y1 = y2 = spaces.b.offset + spaces.b.footer_height
-        self.plot_footer_line.set_xdata([x1, x2])
-        self.plot_footer_line.set_ydata([y1, y2])
-
 
 def _text_is_visible(text: Text) -> bool:
     """

plotnine/_mpl/utils.py

@@ -17,6 +17,8 @@
     from matplotlib.backend_bases import RendererBase
     from matplotlib.figure import Figure
     from matplotlib.gridspec import SubplotSpec
+    from matplotlib.lines import Line2D
+    from matplotlib.patches import Rectangle
     from matplotlib.text import Text
     from matplotlib.transforms import Transform
 
@@ -276,6 +278,35 @@ def max_height(self, artists: Sequence[Artist]) -> float:
         return max(heights) if len(heights) else 0
 
 
+def resize_footer_background(
+    background: Rectangle,
+    x: float,
+    y: float,
+    height: float,
+    width: float,
+):
+    """
+    Resize the plot footer background to the given dimensions
+    """
+    background.set_x(x)
+    background.set_y(y)
+    background.set_height(height)
+    background.set_width(width)
+
+
+def resize_footer_line(
+    line: Line2D,
+    x: float,
+    width: float,
+    y: float,
+):
+    """
+    Resize the footer line to be a horizontal border
+    """
+    line.set_xdata([x, x + width])
+    line.set_ydata([y, y])
+
+
 @dataclass
 class JustifyBoundaries:
     """