BUG: Inherit DEFAULT_PARAMS down the geom and stat class hierarchy - #1073
Merged
Conversation
Subclasses now declare only the parameters that differ from their parent, and the effective merged set is exposed as `default_params`. This fixes geoms rejecting parameters that their parent geom supports: geom_step now accepts lineend, linejoin and arrow, geom_quantile accepts arrow, and geom_histogram accepts just and width. geom_step also renders its corners with the documented round joinstyle, hence the updated baseline images.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1073 +/- ##
==========================================
- Coverage 87.10% 87.08% -0.03%
==========================================
Files 208 208
Lines 14321 14327 +6
Branches 1788 1790 +2
==========================================
+ Hits 12474 12476 +2
- Misses 1283 1286 +3
- Partials 564 565 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subclasses now declare only the parameters that differ from their parent, and the effective merged set is exposed as
default_params. This fixes geoms rejecting parameters that their parent geom supports: geom_step now accepts lineend, linejoin and arrow, geom_quantile accepts arrow, and geom_histogram accepts just and width. geom_step also renders its corners with the documented round joinstyle, hence the updated baseline images.