Skip to content

🛡️ Sentinel: [CRITICAL] Fix command injection in Windows file launch #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
haseeb-heaven wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🛡️ Sentinel: [CRITICAL] Fix command injection in Windows file launch #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .jules/sentinel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
## 2024-07-03 - Windows File Launch Command Injection
**Vulnerability:** `subprocess.call(['start', filename], shell=True)` was used to open files on Windows, creating a command injection risk even with `os.path.isfile()` checks, as legal filenames can contain shell metacharacters (`&`, `^`).
**Learning:** Using `shell=True` with `start` on user-controlled or external paths is inherently unsafe on Windows because the shell parses metacharacters before the application opens the file.
**Prevention:** Always use `os.startfile(filename)` for opening files natively on Windows, bypassing the shell entirely.
2 changes: 1 addition & 1 deletion libs/utility_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def _open_resource_file(self, filename):
try:
if os.path.isfile(filename):
if platform.system() == "Windows":
subprocess.call(['start', filename], shell=True)
os.startfile(filename)
elif platform.system() == "Darwin":
subprocess.call(['open', filename])
elif platform.system() == "Linux":
Expand Down
Loading