🎨 Palette: [UX improvement] Add fallback prompt choices and fix TUI cancel trap#194
🎨 Palette: [UX improvement] Add fallback prompt choices and fix TUI cancel trap#194haseeb-heaven wants to merge 1 commit into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
📝 WalkthroughWalkthroughThis PR updates the terminal UI to detect Ctrl-C as a cancellation signal during raw key reads, appends a cancellation hint to selector footers, adjusts non-interactive prompt text to show bracketed options, and adds a documentation note describing these changes. ChangesTerminal UI cancellation and prompt updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested Reviewershaseeb-heaven 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
libs/terminal_ui.py (1)
40-45: 🩺 Stability & Availability | 🟠 Major | 🏗️ Heavy liftBare Esc still blocks in raw mode.
sys.stdin.read(2)after\x1bwaits for two more bytes, so a lone Esc can hang the selector and a later\x03can be swallowed instead of cancelling. Use a short timeout or non-blocking peek before reading the ANSI tail.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@libs/terminal_ui.py` around lines 40 - 45, The escape-key handling in the terminal input loop blocks because `sys.stdin.read(2)` waits for two more bytes, so a bare Esc can hang and interfere with Ctrl-C handling. Update the logic in the key-read path that checks `'\x1b'` to use a short timeout or non-blocking peek before consuming ANSI tail bytes, and only decode arrow sequences in the selector while letting a lone Esc return immediately as `escape`.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@libs/terminal_ui.py`:
- Around line 40-45: The escape-key handling in the terminal input loop blocks
because `sys.stdin.read(2)` waits for two more bytes, so a bare Esc can hang and
interfere with Ctrl-C handling. Update the logic in the key-read path that
checks `'\x1b'` to use a short timeout or non-blocking peek before consuming
ANSI tail bytes, and only decode arrow sequences in the selector while letting a
lone Esc return immediately as `escape`.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: bcdd897b-1e75-4fb9-bce4-be745d367eec
📒 Files selected for processing (2)
.jules/palette.mdlibs/terminal_ui.py
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 276daf73d8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if key == '\x03': | ||
| raise KeyboardInterrupt('Selection cancelled by user.') |
There was a problem hiding this comment.
When a user presses bare Esc on a POSIX TTY, execution still enters the key == '\x1b' branch immediately below and blocks in sys.stdin.read(2) waiting for an ANSI sequence, so this new Ctrl-C handling is never reached for that stuck read. In that common cancel-key scenario the selector remains trapped until two more bytes are typed, despite the change advertising a reliable cancel path; the Escape path needs a timeout/nonblocking read or equivalent handling.
Useful? React with 👍 / 👎.
1 participant
💡 What: Added explicitly formatted options to fallback inputs (e.g.
[option1|option2]), explicitly handled standard raw mode\x03bytes as aKeyboardInterrupt, and added explicit 'Ctrl-C to cancel' text to footer.🎯 Why: TUI menus can trap users who aren't familiar with raw mode defaults since bare Esc throws hanging reads for ANSI sequences. A prompt without options obscures what can be typed.
📸 Before/After: Visual changes to prompt footers; unblocks raw mode hanging states on bare Esc presses.
♿ Accessibility: Fallback prompts expose options automatically to text-mode non-interactive tools and assistive environments without guessing.
PR created automatically by Jules for task 11699298701496465038 started by @haseeb-heaven
Summary by CodeRabbit
Bug Fixes
Documentation